fix(image): hash payload after the TLV area, jump to entry_addr - #44
Open
Noor-Nabi4 wants to merge 1 commit into
Open
fix(image): hash payload after the TLV area, jump to entry_addr#44Noor-Nabi4 wants to merge 1 commit into
Noor-Nabi4 wants to merge 1 commit into
Conversation
eos_sign.py lays out [header][TLV][payload] and hashes payload only, but verify_integrity hashed from hdr_size and rejected signed images. Skip a well-formed TLV (fail closed if it is corrupt) and jump to entry_addr so copy-to-RAM images boot at the validated vector. Signed-off-by: Noor Nabi <gcnoor6@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Noor-Nabi4
requested review from
hshanmug12,
maheshmunnangi and
srpatcha
as code owners
August 26, 2026 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eos_sign.py lays out [header][TLV][payload] and hashes payload only,
but verify_integrity hashed from hdr_size and rejected signed images.
Skip a well-formed TLV (fail closed if it is corrupt) and jump to
entry_addr so copy-to-RAM images boot at the validated vector.
Signed-off-by: Noor Nabi gcnoor6@gmail.com
Co-authored-by: Cursor cursoragent@cursor.com