Skip to content

refactor: enhance security standards and resolve CI/CD pipeline issues - #11

Merged
srpatcha merged 1 commit into
embeddedos-org:masterfrom
RinZ27:robust/encryption-and-security-standards
Aug 25, 2026
Merged

srpatcha merged 1 commit into
embeddedos-org:masterfrom
RinZ27:robust/encryption-and-security-standards

Conversation

@RinZ27

@RinZ27 RinZ27 commented Apr 18, 2026 •

Copy link
Copy Markdown
Member

Description

Technical updates to improve cryptographic robustness for data at rest and align the container environment with security best practices. These changes resolve a deterministic salt issue and ensure the API follows a configurable CORS policy. Additionally, the CI/CD pipeline has been stabilized by addressing type-checking violations, fixing linting errors, and adding the missing lock file.

Changes

  • Switched to cryptographically secure random salt (os.urandom) in EncryptionManager to enhance key derivation.
  • Added explicit type annotations for class attributes in EncryptionManager to satisfy mypy strict mode.
  • Introduced cors_origins configuration in EDBConfig to eliminate hardcoded wildcard origins in the API layer.
  • Updated Dockerfile to implement a non-root user (edb) and properly manage data directory permissions.
  • Added package-lock.json to resolve frontend CI caching failures.
  • Fixed an unused import and re-organized import blocks to satisfy project-wide ruff linting requirements.

Testing

  • Verified EncryptionManager compatibility with the existing decryption logic through manual inspection.
  • Checked environment variable mapping for the new CORS settings in the local dev environment.
  • Built the Dockerfile locally to confirm successful user creation and permission assignment.
  • Confirmed that ruff check . passes completely for the entire project.
  • Static analysis of type annotations confirms compatibility with strict mypy requirements.

Checklist

  • Code follows project conventions
  • Logic improves system robustness without breaking existing APIs
  • No console errors or warnings in local environment

@RinZ27
RinZ27 requested a review from a user April 18, 2026 04:36
@RinZ27
RinZ27 force-pushed the robust/encryption-and-security-standards branch from 9c1dfc2 to 932edc9 Compare April 18, 2026 04:40
@RinZ27 RinZ27 changed the title refactor: improve encryption robustness and container security standards refactor: enhance security standards and resolve CI/CD pipeline issues Apr 18, 2026
@RinZ27
RinZ27 force-pushed the robust/encryption-and-security-standards branch 6 times, most recently from 2d78c42 to 9f36cae Compare April 18, 2026 05:16
@RinZ27

RinZ27 commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

Noticed the python (3.12) job is failing due to a ModuleNotFoundError: No module named 'edb.core'. It seems src/edb/core/ is missing from the repository entirely, even song most modules and tests depend on it.

Crucially, I found that this directory isn't present on master either, which explains why CI is blocked. I'm ready to tackle the remaining 22 mypy violations once the core logic is restored or pointed to correctly.

Waiting on a review from @hshanmug12, @maheshmunnangi, @rashmiadvani, and @srpatcha to move this forward once we sort out the environment issues.

srpatcha
srpatcha previously approved these changes Aug 17, 2026
@RinZ27
RinZ27 force-pushed the robust/encryption-and-security-standards branch from 76f4cea to a6245ed Compare August 24, 2026 12:28
@RinZ27

RinZ27 commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

@srpatcha @hshanmug12 @maheshmunnangi @rashmiadvani Looks like src/edb/core/ was restored on master, so I just rebased to resolve the merge conflicts. All those mypy type annotation errors are also fixed in this update, which should unblock the python (3.12) CI job.

@srpatcha
srpatcha merged commit 5e436bd into embeddedos-org:master Aug 25, 2026
2 checks passed
@RinZ27
RinZ27 deleted the robust/encryption-and-security-standards branch August 26, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants