fix(consume): map reth BAL account-miss and item-cost rejection messages - #3371
Merged
LouisTsai-Csie merged 2 commits intoAug 14, 2026
Merged
LouisTsai-Csie merged 2 commits into
LouisTsai-Csie merged 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3371 +/- ##
================================================
Coverage 93.53% 93.53%
================================================
Files 624 624
Lines 37074 37074
Branches 3394 3394
================================================
Hits 34679 34679
Misses 1645 1645
Partials 750 750
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
marked this pull request as ready for review
August 13, 2026 15:37
|
LGTM. Clean mapping fixes for the unmapped Reth BAL exceptions. |
LouisTsai-Csie
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fully vibed.
Map two reth rejection messages that currently fail consume-engine with "Undefined exception message" (glamsterdam-quick, fixtures
tests-glamsterdam-devnet@v8.1.0):Bal error: Account .* not found in BAL→INVALID_BLOCK_ACCESS_LIST: reth executes payloads against the BAL as a state overlay, so a corrupted BAL that omits a touched account surfaces this message; for thetest_bal_invalid_*engine cases (~9 fails) the rejection is semantically correct and only unmapped. (Reth also returns this message for blocks that are invalid for gas/system-contract reasons — those tests keep failing on the exception mismatch, now with a clearer diagnostic; that ordering issue is reth-side.)block access list item cost exceeds gas limit→BLOCK_ACCESS_LIST_GAS_LIMIT_EXCEEDED: correct rejections oftest_bal_gas_limit_boundary/test_fork_transition_bal_size_constraintengine cases (~5 fails), only unmapped.Both verified with
message_to_exceptionagainst the exact messages from run 1786545713-b58ee7108bac1061a0e86683cb053c10.Same shape as the geth mapper additions in #3347.
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture
Update: also maps
system contract .* has no code→SYSTEM_CONTRACT_EMPTY, the message introduced by alloy-rs/evm#400 / paradigmxyz/reth#26695 for the EIP-8282 empty-predeploy rejection (covers the 4test_builder_*_contract_deploymentengine fails). Verified both new messages disambiguate fromSYSTEM_CONTRACT_CALL_FAILED.