Repository navigation
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a1fe9d-1fe0-74e3-a495-ee80245a4289 Co-authored-by: Amp <amp@ampcode.com>
🐼 Smoke eval —
|
| question | result | tokens | tools |
|---|---|---|---|
forky_node_coverage |
✅ | 14,278 | 5 |
tracoor_node_coverage |
✅ | 5,330 | 7 |
mainnet_block_arrival_p50 |
✅ | 3,698 | 7 |
list_datasources |
✅ | 1,486 | 2 |
block_count_24h |
✅ | 3,569 | 6 |
missed_slots_24h |
✅ | 8,483 | 12 |
chartkit_default_arrival_distribution |
✅ | 6,637 | 7 |
storage_upload_session_scoped |
✅ | 4,675 | 7 |
evm_faucet_fund_throwaway_address |
✅ | 3,703 | 3 |
🔭 Langfuse traces (9 runs; ⚠️ = failed)
The report walks this branch's commits against the master baseline and the most recent release. A self-contained copy is in the run's eval-smoke-* artifact.
There was a problem hiding this comment.
Summary
Moves all image publishing to GHCR (goreleaser, master and PR builds) and mirrors attested digests to Docker Hub via the image-mirror action, adding attest-only steps in the release job plus a separate mirror job and a concurrency group on master builds. The wiring matches the pinned mirror-image action's contract and the goreleaser artifact format, so the flows should work as described; only two maintenance/housekeeping points below.
Issues
- 🟡
.github/workflows/build-master.yaml:14— queued master runs are dropped once more than one is pending — see the thread on that line - 🟢
.github/workflows/build-and-push.yaml— new action pin has no version comment — All four newuses: ethpandaops/actions/mirror-image@738aea…lines (here line 158, and.github/workflows/goreleaser.yaml136, 143, 160) are pinned by SHA without a# vX.Y.Zcomment, unlike the other 62uses:pins in these workflows;.github/dependabot.ymldocuments that the grouped actions update relies on SHA-plus-version-comment refs, so this third-party action (which holdsid-token/attestationspowers) won't be bumped by Dependabot.
Reviewed @ 5d980485
"Bad pennies always come back." — Hungarian variant
| # an older run can't fail at the mirror after a newer one moved them. | ||
| concurrency: | ||
| group: docker-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
🟡 queued master runs are dropped once more than one is pending
GitHub keeps at most one running and one pending run per concurrency group, and cancel-in-progress: false only stops the running one from being cancelled — a third push cancels the pending run. So a burst of merges means an intermediate commit's master-<sha> / server-master-<sha> / ... tags are never published even though the workflow appears to have run (previous behaviour built every commit). Worth confirming that's acceptable, since the comment above says runs simply queue.
Releases and master/PR image builds no longer need a Docker Hub token.
Releases (
goreleaser.yaml)self-hosted-ghr,size-l-x64) toubuntu-latest. Nothing in the build steps needs the self-hosted runner. The multi-arch sandbox build still uses QEMU for arm64, as before, so it may take longer on a standard runner.ghcr.io/ethpandaops/pandawith the job's ownGITHUB_TOKEN. The job already had the permissions it needs.mirrorjob then asks the image mirror to copy exactly those digests todocker.io/ethpandaops/panda, and only goes green once they're on Docker Hub. If the mirror fails, "Re-run failed jobs" retries only the mirror and never rebuilds the images.Sign imagesnow signs the GHCR images. The cosign signatures stay on GHCR: cosign signature tags aren't copied to Docker Hub, so the Docker Hub images no longer carry them.docs/verifying-releases.mdnow says to runcosign verifyagainstghcr.io/ethpandaops/panda:<version>, which has the same digest as the Docker Hub image. That needs theghcr.io/ethpandaops/pandapackage to be public.Master and PR builds (
build-and-push.yaml, called bybuild-master.yamlandbuild-pr.yaml)ubuntu-latest. It only runsgo buildanddocker buildx.IMAGE_MIRROR_URLinstead of the Docker Hub secrets, and the two callers grant the jobpackages: write,id-token: writeandattestations: write.*-master-latesttags.metajob, whose short SHA goes into the image tags, moves toubuntu-latesttoo. Thecommentjob stays on the self-hosted runners; it only posts the PR comment.The Docker Hub image names and tags are unchanged everywhere.
Heads-up, not changed here:
build-pr.yamlpublishes images from PRs:pr-<N>andpr-<N>-<sha>tags for each image, onpull_request(notpull_request_target), only for same-repo PRs with thebuildlabel. That's unchanged; those tags now go through the mirror like the rest.Once a release has gone through, the repo's
DOCKERHUB_USERNAMEandDOCKERHUB_TOKENsecrets can be removed. Nothing in this repo uses them after this PR.Same approach as ethpandaops/ethereum-address-metrics-exporter#70 and ethpandaops/ethereum-address-metrics-exporter#71, which went through end to end on real releases. Needs the
IMAGE_MIRROR_URLorganization secret, which is already in place.