Skip to content

Publish images through GHCR and the image mirror - #412

Open
samcm wants to merge 3 commits into
masterfrom
image-mirror
Open

samcm wants to merge 3 commits into
masterfrom
image-mirror

Conversation

@samcm

@samcm samcm commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Releases and master/PR image builds no longer need a Docker Hub token.

Releases (goreleaser.yaml)

  • The release job moves from the self-hosted runners (self-hosted-ghr, size-l-x64) to ubuntu-latest. Nothing in the build steps needs the self-hosted runner. The multi-arch sandbox build still uses QEMU for arm64, as before, so it may take longer on a standard runner.
  • Goreleaser (server, CLI and proxy) and the sandbox build push to ghcr.io/ethpandaops/panda with the job's own GITHUB_TOKEN. The job already had the permissions it needs.
  • Two attest steps at the end of the release job attest the pushed digests: one for everything goreleaser pushed, one for the three sandbox tags. A separate mirror job then asks the image mirror to copy exactly those digests to docker.io/ethpandaops/panda, and only goes green once they're on Docker Hub. If the mirror fails, "Re-run failed jobs" retries only the mirror and never rebuilds the images.
  • Sign images now signs the GHCR images. The cosign signatures stay on GHCR: cosign signature tags aren't copied to Docker Hub, so the Docker Hub images no longer carry them. docs/verifying-releases.md now says to run cosign verify against ghcr.io/ethpandaops/panda:<version>, which has the same digest as the Docker Hub image. That needs the ghcr.io/ethpandaops/panda package to be public.

Master and PR builds (build-and-push.yaml, called by build-master.yaml and build-pr.yaml)

  • The build job moves from the self-hosted runners to ubuntu-latest. It only runs go build and docker buildx.
  • The four images push to GHCR. One step at the end attests every pushed digest and mirrors all the tags. The reusable workflow now takes IMAGE_MIRROR_URL instead of the Docker Hub secrets, and the two callers grant the job packages: write, id-token: write and attestations: write.
  • Master runs now queue instead of overlapping, since every run moves the *-master-latest tags.
  • The meta job, whose short SHA goes into the image tags, moves to ubuntu-latest too. The comment job stays on the self-hosted runners; it only posts the PR comment.

The Docker Hub image names and tags are unchanged everywhere.

Heads-up, not changed here: build-pr.yaml publishes images from PRs: pr-<N> and pr-<N>-<sha> tags for each image, on pull_request (not pull_request_target), only for same-repo PRs with the build label. That's unchanged; those tags now go through the mirror like the rest.

Once a release has gone through, the repo's DOCKERHUB_USERNAME and DOCKERHUB_TOKEN secrets can be removed. Nothing in this repo uses them after this PR.

Same approach as ethpandaops/ethereum-address-metrics-exporter#70 and ethpandaops/ethereum-address-metrics-exporter#71, which went through end to end on real releases. Needs the IMAGE_MIRROR_URL organization secret, which is already in place.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

🐼 Smoke eval — 5d98048: ✅ 9/9 pass

📊 Interactive report — tokens p50 4,675 · tokens/solve 5,762.

Reference points: master@c642227 100% · image-mirror@ba69189 100% · image-mirror@d356282 100%.

question result tokens tools
forky_node_coverage ✅ 14,278 5
tracoor_node_coverage ✅ 5,330 7
mainnet_block_arrival_p50 ✅ 3,698 7
list_datasources ✅ 1,486 2
block_count_24h ✅ 3,569 6
missed_slots_24h ✅ 8,483 12
chartkit_default_arrival_distribution ✅ 6,637 7
storage_upload_session_scoped ✅ 4,675 7
evm_faucet_fund_throwaway_address ✅ 3,703 3
🔭 Langfuse traces (9 runs; ⚠️ = failed)

The report walks this branch's commits against the master baseline and the most recent release. A self-contained copy is in the run's eval-smoke-* artifact.

@redpandabot redpandabot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Moves all image publishing to GHCR (goreleaser, master and PR builds) and mirrors attested digests to Docker Hub via the image-mirror action, adding attest-only steps in the release job plus a separate mirror job and a concurrency group on master builds. The wiring matches the pinned mirror-image action's contract and the goreleaser artifact format, so the flows should work as described; only two maintenance/housekeeping points below.

Issues

  • 🟡 .github/workflows/build-master.yaml:14 — queued master runs are dropped once more than one is pending — see the thread on that line
  • 🟢 .github/workflows/build-and-push.yaml — new action pin has no version comment — All four new uses: ethpandaops/actions/mirror-image@738aea… lines (here line 158, and .github/workflows/goreleaser.yaml 136, 143, 160) are pinned by SHA without a # vX.Y.Z comment, unlike the other 62 uses: pins in these workflows; .github/dependabot.yml documents that the grouped actions update relies on SHA-plus-version-comment refs, so this third-party action (which holds id-token/attestations powers) won't be bumped by Dependabot.

Reviewed @ 5d980485
"Bad pennies always come back." — Hungarian variant

# an older run can't fail at the mirror after a newer one moved them.
concurrency:
group: docker-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 queued master runs are dropped once more than one is pending

GitHub keeps at most one running and one pending run per concurrency group, and cancel-in-progress: false only stops the running one from being cancelled — a third push cancels the pending run. So a burst of merges means an intermediate commit's master-<sha> / server-master-<sha> / ... tags are never published even though the workflow appears to have run (previous behaviour built every commit). Worth confirming that's acceptable, since the comment above says runs simply queue.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant