fix(bootstrap): gate npm registry config on corp gcloud account

[evansenter]

Problem

On ./bootstrap.sh -p, configure_npm_registry ran gcloud artifacts print-settings npm against the internal ah-3p-staging-npm Artifact Registry repo for any active gcloud account. On a personal account (e.g. gmail.com) that call returns PERMISSION_DENIED, so the function fell into its else branch and printed:

  Warning: Failed to configure NPM credentials automatically

every single -p run. It's harmless — public npm installs already pass --registry https://registry.npmjs.org/ explicitly and no ~/.npmrc entry is needed — but it's noise on personal machines.

Fix

Add a CORP_NPM_DOMAIN="@anthropic.com" constant and skip configure_npm_registry silently unless the active gcloud account ends in that domain. Corp machines behave exactly as before; personal machines no-op cleanly.

Tests

Two new behavioral tests in tests/test-bootstrap.sh that load the real constant + function from bootstrap.sh (via sed/grep, same pattern as the existing is_gateway_host tests), stub gcloud/npm on PATH, and assert via a marker file:

• npm registry skips personal gcloud account — gmail.com account never reaches print-settings, never writes ~/.npmrc
• npm registry runs for corp gcloud account — @anthropic.com account does both

Mutation-verified: removing the gate flips the personal-account test to red. make check green (lint, 37 bootstrap tests, hooks).

🤖 Generated with Claude Code

[claude]

Prompt: claude-review.md

Code Review — Summary

Gates configure_npm_registry on the active gcloud account ending in @anthropic.com, silencing the spurious PERMISSION_DENIED warning on personal machines. The fix is minimal, correctly placed, and covered by two behavioral tests that load the real constant + function from bootstrap.sh (via sed/grep, same pattern as the is_gateway_host tests).

Notes

• Gate logic is correct: the leading @ in the constant anchors the suffix match, so lookalike domains (e.g. foo@evil-anthropic.com) cannot falsely match — only genuine @anthropic.com accounts proceed.
• Placement is right: the gate sits after the command-v / active-account checks and before the print-settings call, so personal accounts no-op silently as intended (no warning).
• Tests cover both branches; the corp path also verifies ~/.npmrc is written, and the env assignments are command-scoped (no PATH/HOME leakage). The sed extraction correctly relies on the function's closing brace at column 0.

Verdict: APPROVE — Clean, well-tested fix with no Critical/Important/Suggestion findings.

(Note: posted via gh pr review because the gh api inline-review path was blocked by the sandbox; this review has no inline comments, so no information is lost.)

Automated review by Claude Code

[evansenter]

Closing as superseded by 09a288d, which rewrote configure_npm_registry so a failed gcloud artifacts print-settings (the personal-account PERMISSION_DENIED case) silently no-ops — the "Warning: Failed to configure NPM credentials automatically" noise this PR existed to suppress no longer occurs. The corp-domain gate would now only skip one silent gcloud call, and the diff/tests target the pre-refactor function shape.

---

Generated by Claude Code