fix(instance): stop Connect/advanced-settings from wiping config

[cesar-carlos]

Summary

• Fixes silent reset of events, rabbitmqEnable, and advanced flags (Instance settings silently reset to defaults (rabbitmqEnable, events, flags) without container restart #111).
• POST /instance/connect is now a partial update: empty fields keep persisted values; MESSAGE is only the default when events is empty.
• PUT /instance/{id}/advanced-settings uses *bool so omitted keys are not written as false.
• Adds unit tests for connect merge and advanced update map building.

Closes #111

Test plan

• go test ./pkg/instance/service/ ./pkg/instance/repository/
• go vet ./pkg/instance/...
• go build ./cmd/evolution-go/
• Manual: configure rabbitmq + ALL events + advanced flags, then POST /instance/connect with {} / empty strings and confirm settings stay
• Manual: PUT .../advanced-settings with only {"alwaysOnline":true} and confirm other flags unchanged

Made with Cursor

Summary by Sourcery

Make instance connect and advanced settings updates partial to avoid unintentionally resetting existing configuration.

Bug Fixes:

• Preserve existing event subscriptions and RabbitMQ settings when /instance/connect is called with empty or partial fields.
• Prevent advanced settings PUT requests from overwriting unspecified flags with false by using pointer-based fields and selective DB updates.

Enhancements:

• Return fully persisted advanced settings after updates so clients see the authoritative state.
• Introduce a dedicated UpdateConnectSettings repository method and helper logic to build partial connect updates.
• Convert advanced settings retrieval to use pointer helpers for consistency in responses.

Tests:

• Add unit tests for connect settings application to ensure events and producer flags are merged correctly.
• Add unit tests for advanced settings update map construction to verify only explicitly provided fields are persisted.

[sourcery-ai]

Sorry @cesar-carlos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

Makes /instance/connect a partial update that only changes explicitly provided fields (preserving existing events and producer flags), switches advanced settings to pointer-based booleans with selective DB updates, and adds tests/utilities to validate the new merge behavior.

Sequence diagram for partial /instance/connect update behavior

sequenceDiagram
  actor Client
  participant InstanceHandler
  participant InstanceService
  participant applyConnectSettings
  participant InstanceRepository
  participant WhatsmeowService

  Client->>InstanceHandler: POST /instance/connect
  InstanceHandler->>InstanceService: Connect(data, instance)
  InstanceService->>applyConnectSettings: applyConnectSettings(instance, data)
  applyConnectSettings-->>InstanceService: updates map[string]interface{}
  alt updates not empty
    InstanceService->>InstanceRepository: UpdateConnectSettings(instance.Id, updates)
    InstanceRepository-->>InstanceService: error or nil
  end
  InstanceService->>WhatsmeowService: UpdateInstanceSettings(instance.Id)
  WhatsmeowService-->>InstanceService: error or nil
  InstanceService-->>InstanceHandler: instance, instance.Jid, eventString
  InstanceHandler-->>Client: 200 OK with events from splitSubscribedEvents(instance.Events)

Loading

File-Level Changes

Change	Details	Files
Connect endpoint now performs partial updates and persists only explicitly provided connect settings.	Refactored Connect to delegate merge logic to applyConnectSettings, which builds a DB updates map based on non-empty incoming fields. Made events subscription logic default to MESSAGE only when both the request and persisted Events are empty. Added splitSubscribedEvents helper to derive subscribedEvents from persisted instance.Events instead of the request body. Introduced repository method UpdateConnectSettings to apply only the computed connect-related field changes in the database. Added logging around changes to events and rabbitmqEnable to surface unexpected config modifications.	pkg/instance/service/instance_service.go pkg/instance/service/connect_settings.go pkg/instance/repository/instance_repository.go pkg/instance/service/connect_settings_test.go
Advanced settings use pointer booleans and selective updates to avoid overwriting unspecified flags.	Changed AdvancedSettings struct bools to *bool so JSON omissions are distinguishable from explicit false. Updated Create and GetAdvancedSettings to write/read AdvancedSettings using pointer-aware assignment and BoolPtr helper. Introduced buildAdvancedSettingsUpdates to construct a partial updates map that only includes non-nil booleans and non-empty MsgRejectCall. Updated UpdateAdvancedSettings to use buildAdvancedSettingsUpdates and early-return when there are no fields to persist. Adjusted handler UpdateAdvancedSettings to re-fetch and return persisted settings after update so responses reflect stored values. Added tests for buildAdvancedSettingsUpdates to ensure only intended fields are written.	pkg/instance/model/instance_model.go pkg/instance/service/instance_service.go pkg/instance/repository/instance_repository.go pkg/instance/handler/instance_handler.go pkg/instance/repository/advanced_settings_test.go

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#111	Prevent /instance/connect from silently resetting Events and RabbitMQ-related settings when fields are omitted, while still defaulting Events to MESSAGE only when no prior value exists, and log changes when these fields are modified.	✅
#111	Make /instance/{id}/advanced-settings a true partial update so omitted boolean flags are not overwritten (e.g., to false), persist only explicitly provided fields, and return the fully persisted settings after update.	✅
#111	Fix the behaviour where an instance stuck in a Reconnecting state causes /instance/qr to never return a QR code, preventing re-pairing.	❌	The PR changes only connect and advanced-settings logic (partial updates, pointer booleans, logging, tests) and does not modify QR code or reconnection handling, so the issue of /instance/qr never returning during a Reconnecting loop remains unaddressed.

Possibly linked issues

• Instance settings silently reset to defaults (rabbitmqEnable, events, flags) without container restart #111: The PR makes Connect and advanced-settings partial updates, preventing silent resets of events, rabbitmqEnable, and advanced flags.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.