Skip to content

Preserve disabled state when renaming pipeline components - #14062

Open
AryanRG wants to merge 1 commit into
explosion:masterfrom
AryanRG:fix/rename-disabled-component
Open

AryanRG wants to merge 1 commit into
explosion:masterfrom
AryanRG:fix/rename-disabled-component

Conversation

@AryanRG

@AryanRG AryanRG commented Oct 26, 2026

Copy link
Copy Markdown

Description

Renaming a disabled component currently enables it and leaves the old name in the disabled list. Keep the disabled state under the new name and synchronize the internal name of trainable components, so they can be re-enabled and trained normally.

Fixes #14061.

Added regressions for active and disabled components, reusing the old name, and training/logging after a rename. The affected pipeline, language, analysis and serialization tests pass locally on macOS with Python 3.12.

Types of change

Bug fix.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed. The affected suites pass; the full suite has not been run locally.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renaming a disabled pipeline component enables it

1 participant