Bump GraphQL codegen dependencies to patch immutable - #3972
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3972 +/- ##
=======================================
Coverage 60.57% 60.57%
=======================================
Files 955 955
Lines 42069 42069
Branches 8832 8832
=======================================
Hits 25480 25480
Misses 16495 16495
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
sjchmiela
left a comment
There was a problem hiding this comment.
By yarn.lock this is a much bigger change than just immutable.
855104e to
2de4ff5
Compare
…dependabot-295-immutable # Conflicts: # CHANGELOG.md # yarn.lock
|
✅ Thank you for adding the changelog entry! |
|
Can you confirm if this is still needed after #4009? |
douglowder
left a comment
There was a problem hiding this comment.
This looks ok, although the yarn.lock diff is large enough to be a little concerning...
|
Closing this. @szdziedzic please rebase against main, and reopen if you find that this is still needed. |
Why
Resolve https://github.com/expo/eas-cli/security/dependabot/295 by removing the vulnerable transitive
immutable@3.7.6dependency without overriding its declared semver range.How
Re-resolved the existing
@graphql-tools/relay-operation-optimizer@^7.0.0dependency to7.1.6. Its current dependency chain selects:@ardatan/relay-compiler@13.0.1@graphql-tools/utils@11.2.0immutable@5.1.9This removes the top-level Yarn resolution and deletes the legacy Relay/Babel dependency subtree from the lockfile. The direct GraphQL Codegen dependencies remain unchanged.
Updated the changelog entry to describe the transitive GraphQL codegen upgrade.
Security
immutable@5.1.9is newer than the patched5.1.5release for GHSA-wf6x-7x77-mvgw.y18n@4.0.0path.Test Plan
corepack yarn oxfmt package.json CHANGELOG.md yarn.lockcorepack yarn install --immutable --check-resolutionscorepack yarn why immutable -RGRAPHQL_SCHEMA_URL=./graphql.schema.json corepack yarn workspace eas-cli generate-graphql-codecorepack yarn buildcorepack yarn typecheckcorepack yarn lint(0 errors, 14 warnings after merging current main)corepack yarn fmt:check package.json CHANGELOG.md yarn.lockcorepack yarn lint-changelogcorepack yarn npm audit --all --recursive --no-deprecations --json(no advisories for the upgraded chain; unrelated monorepo findings remain)git diff --check