externpro 26.01.5-26-g734f91b sync - #6
Merged
Merged
Conversation
- Replace USE_CMAKE_ICONV with USE_LIBICONV in presets - Use find_package(libiconv) instead of find_package(Iconv) to avoid hard-coded build system paths in targetsFile - Map libiconv_FOUND/LIBICONV_LIBRARIES to ICONV_FOUND/ICONV_LIBRARIES - Remove Iconv find_package from xpExternPackage use script
- Move USE_LIBICONV from CMakePresetsBase.json to CMakeLists.txt - Set USE_LIBICONV ON when xpExternPackage is available, OFF otherwise - Avoids cmake warning about unused manual cmake variable USE_LIBICONV on non-Apple platforms that don't set USE_ICONV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01.5-26-g734f91bChanges
.devcontainerto externpro26.01.5-26-g734f91b67ba29e63e008035d449ef51eeb0e953dacddf54734f91b27d5024e19f7945efc565929fc5c788ee.github/release-tag.json(tag:xpv1.3.0.5)This PR was created automatically by GitHub Actions