Support SimpleCov 1.0 - #140
Open
mateusdeap wants to merge 2 commits into
Open
Conversation
JuanVqz
approved these changes
Jul 30, 2026
JuanVqz
left a comment
JuanVqz
left a comment
Member
There was a problem hiding this comment.
LGTM.
There are some deprecations we are raising, probably we cannot fix yet because we are supporting old ruby versions, not that old like next_rails... but I didn't check.
test/test_helper.rb:19: three APIs simplecov 1.0 deprecates, so skunk.yml CI job now prints deprecation noise every run.
Reproduced under 1.0.3:
add_filterlines 19, 20 → Replace withSimpleCov.skiptrack_filesline 22 → Replace withSimpleCov.cover
| spec.add_development_dependency "reek" | ||
| spec.add_development_dependency "rubocop" | ||
| spec.add_development_dependency "simplecov", "~> 0.18" | ||
| spec.add_development_dependency "simplecov", ">= 0.18" |
Member
There was a problem hiding this comment.
Otherwise, simplecov will include v2 silently
Suggested change
| spec.add_development_dependency "simplecov", ">= 0.18" | |
| spec.add_development_dependency "simplecov", ">= 0.18", "< 2" |
|
|
||
| ## main [(unreleased)](https://github.com/fastruby/skunk/compare/v0.5.4...HEAD) | ||
|
|
||
| * [FEATURE: Support SimpleCov 1.0](https://github.com/fastruby/skunk/pull/140) |
Member
There was a problem hiding this comment.
enhancement feeds better, but we have FEATURE: Add Ruby 3.4 compatibility so, fine:
Suggested change
| * [FEATURE: Support SimpleCov 1.0](https://github.com/fastruby/skunk/pull/140) | |
| * [ENHANCEMENT: Support SimpleCov 1.0](https://github.com/fastruby/skunk/pull/140) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.Description
Adds support for SimpleCov 1.0 in development
I will abide by the code of conduct.