Remove static route entries in FIB for nexthops that become unreachable - #4833
Merged
Merged
Conversation
gizmoguy
force-pushed
the
del-dead-nexthop-static-routes
branch
3 times, most recently
from
July 31, 2026 02:20
16acce2 to
601f9e7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4833 +/- ##
==========================================
+ Coverage 91.49% 91.51% +0.02%
==========================================
Files 46 46
Lines 8938 8940 +2
==========================================
+ Hits 8177 8181 +4
+ Misses 761 759 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gizmoguy
force-pushed
the
del-dead-nexthop-static-routes
branch
4 times, most recently
from
July 31, 2026 03:03
73706dd to
18eb45e
Compare
gizmoguy
force-pushed
the
del-dead-nexthop-static-routes
branch
from
September 16, 2026 21:57
18eb45e to
5c49d72
Compare
anarkiwi
approved these changes
Sep 29, 2026
gizmoguy
force-pushed
the
del-dead-nexthop-static-routes
branch
from
September 30, 2026 00:26
5c49d72 to
7ea0392
Compare
anarkiwi
pushed a commit
to c65sdn/faucet
that referenced
this pull request
Oct 4, 2026
Cherry-pick key upstream commits enabling warm start for routed VLANs: - PR faucetsdn#4815: Fix deleting final ACL from a port / del_vlan flowdel suppression - PR faucetsdn#4819: ACL-only VLAN warm start without cold restart - PR faucetsdn#4833: Remove static route entries from FIB for dead nexthops - PR faucetsdn#4850: Enable warm start for VLANs with routing enabled Adapted for c65of import namespace (fork divergence from os_ken). Key changes: - dp.py: separate tracking of added/changed/deleted/acl-only VLANs - valve.py: proper warm start flow with nexthop expiry for sibling routed VLANs - valve_route.py: expire nexthops, del_faucet_mac/vip flow cleanup, IPv4/IPv6 - valve_acl.py, valve_manager_base.py, valve_switch_standalone.py: signature updates - valve_of.py: make _flowmodkey tuple comparable - test infrastructure: l2_learn_host, l3_learn_host helpers, cold_start fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a gateway becomes unreachable that is a nexthop for a static route, only the host route is removed from the FIB, not the static routes.
This patch also expires the static routes to prevent unusable routes from existing in the FIB.
The test case for this patch requires the fix from #4827 to pass