Repository navigation
feat(system-config): advertise the provider a native admin tool uses - #153
Merged
Merged
Conversation
Adds the oidc_cli_client_id system config key and an optional oidcProvider on the public config response (ADR 0003). The field is optional and the key defaults to null, so a client on this version still reads an older API's answers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a native admin tool learn the instance's OpenID Provider (ADR 0003, fells-code/seamless-cli#316).
oidc_cli_client_id: string or null, naming the application a native admin tool signs in with.oidcProvider: { issuer, cliClientId }.Optional on purpose: the previous response shape still parses, and an older admin config reads the new key as
null. Tests pin both, after 0.36.0 made a new response field required and broke clients on older APIs (#151).Merge and release this first, as a minor, presumably 0.37.0. The API branch
feat/public-oidc-providerdepends on it. typecheck, lint, prettier and build pass; 553 tests.