Fix compiler and CPAN tooling across legacy modules - #919
Merged
Conversation
Preserve fork-open state while Git.pm redirects child filehandles, resume through nested helper calls at the opening Perl frame, and attach captured process output to the original filehandle. Also propagate active @inc paths through Module::Build helper processes so generated scripts can load staged dependencies such as B::Keywords. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Strip shell-protection quotes from -s assignments and parse `$#{@{...}}`
as an array last-index expression instead of hash access. This makes the
corresponding Perl compatibility tests pass without changing the tests.
Generated with [Codex](https://openai.com/codex)
Co-Authored-By: Codex <codex@openai.com>
Give io/through.t and io/crlf_through.t twice the configured per-test timeout because their pipe matrix launches hundreds of child processes. Keep the multiplier proportional to custom --timeout values and leave other tests unchanged. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Narrow the Class::DBI distropref match, preserve numbered captures beside named recursive regex groups, and make fixed-point sprintf rounding match Perl's ties-to-even behavior. Return packed gethostbyname addresses directly in scalar context and route the opcode through the interpreter, removing the Socket fallback that hid the incorrect scalar result. Generated with [Codex](https://openai.com/codex) Co-Authored-By: Codex <223018245+openai-codex[bot]@users.noreply.github.com>
fglock
force-pushed
the
fix/git-repo-commits-tooling
branch
2 times, most recently
from
August 11, 2026 12:18
ed469ce to
d2b8977
Compare
fglock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@INCpaths through Module::Build helpers.-shandling, array last-index parsing, and timeout allocation for subprocess-heavy core tests.sprintfbehavior for Games::Ratings.gethostbynameaddresses correctly in scalar context and dispatch the opcode in the interpreter.This unifies the original Git::Repo::Commits / Perl::Critic tooling work with the compiler and CPAN tooling fixes found while testing Class::DBI::Search::Count, Net::Radius::Server, String::Format, Games::Ratings, and their dependencies.
Validation
make— passed after the unified rebase./jcpan -t Git::Repo::Commits— 13/13 tests passed in the original PR validation./jcpan -t Class::DBI::Search::Count— 5 tests passed./jcpan -t String::Format— 21 tests passed./jcpan -t Games::Ratings— 123 tests passedNet::Radius::Server itself fails under clean system Perl on upstream
strict subsconstant errors. Authen::PAM also fails system-Perl configuration, and BerkeleyDB requires XS. Those user-approved ignore cases were not patched; the underlying AutoSplit/regex and scalargethostbynamedefects exposed by the dependency chain were fixed instead.Final unified acceptance testing will be performed by the user.