Repository navigation
fix(f1040): validate solo 401(k), SSTB QBI and safe-harbor inputs - #171
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-employed estimates can deduct an excessive solo 401(k) contribution or stop when a valid, reviewed SSTB retirement deduction needs owner attribution. Missing prior-year AGI can also silently select the lower safe-harbor rate. This fixes those paths while retaining source-reconciliation and final-filing guards.
Closes #170.
Changes
The new regression tests use independently chosen synthetic amounts and invalid test identifiers. They are under
forms/f1040/nodes/..., so the standard forms CI gate discovers them. The source/contract note links the IRS worksheets and statutes. No benchmark expectations, tolerance, failure baseline, production network policy, IRS schema or filing-source guard is relaxed.Verification
Tested commit:
488675e88736a11b1690455f6eb9bbfbc49e8d90, based on current main3add1ba73e84897a7c1f5d955c83866836e2d7fc.test:unit: 383 tests reported, 0 failures, one unavailable WSDL-schema prerequisite skipped; gate passed.test:forms: 8,349 tests reported, 35 existing baselined private-asset failures, 264 prerequisite skips; zero unbaselined failures and gate passed. The failure baseline is unchanged.check:structure,check:sandbox,check:cases,check:oracle,check:mef,check:ty2026,check:cliandcheck:irs: passed.The TY2025 legacy benchmark still has 22 passing and 87 failing cases. Compared with unchanged main, its counts and all 87 failed-case numerical differences/errors/unsupported keys are identical. The benchmark does not pass overall, and no goldens were edited to make it appear green. Upstream has no TY2026 benchmark case directory; explicit TY2026 regressions and the TY2026 sample gate cover these paths.
Local broad checks were run from an exact-commit clean checkout with canonical temporary paths, public IRS templates and the required PDF tools. This avoids existing macOS URL/temp-path and missing-tool failures without changing the tests.
Review boundaries
Positive legacy solo 401(k) inputs now require an explicit reconciled earnings basis. The employer worksheet uses the maximum 25% plan rate; a lower actual plan rate still needs review. Catch-up and multiple-plan arrangements outside the represented facts remain unsupported, rather than assumed valid.
The basic vehicle worksheet issue is already fixed upstream in #164, so mileage behavior is unchanged here. A separate local payment-planning command is not part of this contribution.
This is a draft calculation/source-validation contribution. Full private-evidence PDF/XSD/ATS coverage, source-document authenticity, IRS acceptance and TY2027 support are not claimed.