Repository navigation
fix(form8995a): accept REIT 1099-DIV amounts with cents - #174
Merged
Merged
Conversation
Issued 1099-DIVs report box 1a and box 5 in cents. reitDividendSourceSchema required whole dollars, so Form 8995 dropped real sources at the 8995-A handoff and line 28 failed its source check. Allow cents and compare the source total to line 28 to the cent. Follow-up to filedcom#172.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #172.
Issued 1099-DIVs report box 1a and box 5 in cents, and the
f1099divinput accepts them.reitDividendSourceSchema(the 8995-A REIT source row) required whole dollars, so Form 8995's handoff dropped every real source with cents, and 8995-A then failed its line 28 source check. #172's tests used whole dollars, so they missed it.This allows cents in the source rows and compares their total to line 28 to the cent. Line 28 itself is unchanged, as is the whole-dollar rounding when it is filed.
Proof
form8995a_reit_sources.test.ts: two 1099-DIVs with box 5 = 1,000.25 and 1,000.35 give line 13 = 400.12 before filing rounding, with no diagnostics. It fails onmainwith the line 28 source error and passes here.mainit gets no QBI deduction.check:structure,check:oracle,test:unit(with type check),check:mef,check:cliandcheck:sandboxpass. The REIT and business-deduction tests pass (319).Not verified
forms/f1040/2025/mef/forms/deductions/business/fail in my checkout and identically on unmodifiedmain: they need the uncommitted IRS XSDs underirs/mef/2025v5.4/.