Skip to content

Code Quality: Optimize navigation performance - #18939

Merged
yair100 merged 4 commits into
files-community:mainfrom
hez2010:navigation-perf
Sep 10, 2026
Merged

yair100 merged 4 commits into
files-community:mainfrom
hez2010:navigation-perf

Conversation

@hez2010

@hez2010 hez2010 commented Sep 10, 2026

Copy link
Copy Markdown
Member
  • Reuse row styles until the layout or size changes.
  • Eliminate duplicate preference probes and unnecessary registry writes.
  • Move Git discovery, Recent Items updates, and fallback access checks off the UI thread.
  • Guard against stale navigation results and disposed pages.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-10T16:30:47.335556Z b6f1027 PR opened
🔒 Security Review ✅ Completed 2026-09-10T16:26:06.383047Z b6f1027 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6f1027437

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Files.App/Files.App.csproj Outdated
Comment thread src/Files.App/ViewModels/ShellViewModel.cs

@yair100 yair100 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Sep 10, 2026
@yair100
yair100 merged commit e8e1df5 into files-community:main Sep 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants