[fix] inject registry as plain values to fix CEL validation - #820
Merged
Conversation
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
4 tasks
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
Fkuloff
marked this pull request as ready for review
August 14, 2026 12:32
ipaqsa
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
InjectRegistryValuewrote the*Registrystruct straight into the module values tree; it now writes a plainmap[string]anywith the same JSON shape.What this PR does / why we need it
CEL validation of
x-deckhouse-validationsconverts values withstructpb, which accepts only maps, slices and scalars, so every hook values patch failed withconvert values to struct: proto: invalid type: *modules.Registry. It hits any module that has a root-level validation rule and an injected registry, i.e. every module delivered from aModuleSource.The typed pointer reached the validator because
calculateResultValuesleaves the merged map as is while there are no patches yet —ApplyValuesPatchreturns early — so the first patch of the first hook already failed and the module never converged.Special notes for your reviewer
castays omitted when empty, mirroring theomitemptytag, so rendered values and their checksum do not change.