Skip to content

fix(testing): register extenders before enabling test extensions (#4600) #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wakqasahmed wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

fix(testing): register extenders before enabling test extensions (#4600) #5039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions php-packages/testing/src/integration/Extend/OverrideExtensionManagerForTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,17 @@ public function extend(Container $container, ?Extension $extension = null): void
$container->singleton(ExtensionManager::class, ExtensionManagerIncludeCurrent::class);
$extensionManager = $container->make(ExtensionManager::class);

$extensionManager->booted = true;
$extensionManager->extend($container);

// Let enable() run instead of treating the test-selected extensions as already enabled.
$extensionManager->booted = false;

foreach ($this->extensions as $extension) {
$extensionManager->enable($extension);
}

$extensionManager->booted = true;

$extensionManager->extend($container);
}
}
}
1 change: 1 addition & 0 deletions php-packages/testing/tests/extend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Flarum\Extend;

return [
new Extend\Locales(__DIR__.'/locale'),
(new Extend\Settings)->serializeToForum('notARealSetting', 'not.a.real.setting'),
(new Extend\Frontend('forum'))->route('/added-by-extension', 'added-by-extension')
];
2 changes: 2 additions & 0 deletions php-packages/testing/tests/locale/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
flarum-testing-tests:
test: Translation from extension
11 changes: 11 additions & 0 deletions php-packages/testing/tests/tests/integration/TestCaseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Flarum\Extend;
use Flarum\Extension\ExtensionManager;
use Flarum\Foundation\Config;
use Flarum\Locale\Translator;
use Flarum\Settings\DefaultSettingsRepository;
use Flarum\Settings\SettingsRepositoryInterface;
use Flarum\Testing\integration\TestCase;
Expand Down Expand Up @@ -121,6 +122,16 @@ public function current_extension_considered_enabled_after_boot()
$this->assertTrue($enabled);
}

#[Test]
public function current_extension_locales_applied_if_specified()
{
$this->extension('flarum-testing-tests');

$translator = $this->app()->getContainer()->make(Translator::class);

$this->assertEquals('Translation from extension', $translator->trans('flarum-testing-tests.test'));
}

#[Test]
public function can_apply_extenders()
{
Expand Down