Conversation
6ecd324 to
58b3985
Compare
Bundle size report (gzip)
119 chunks compared, 24 changed. Sizes are gzip, matching what nginx serves. |
Signed-off-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
58b3985 to
a5a21b8
Compare
|
Hi @pedrolamas, rebased on the latest |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is localized to the thermals chart update path and addresses the described ECharts interaction regression without introducing broader behavioral risk.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Keeps ECharts’ axis pointer/tooltip “locked” to the mouse position across frequent setOption dataset updates in the Thermals widget, so highlighted symbols and the pointer line don’t disappear/drift while the mouse is stationary.
Changes:
- Track the latest mouse position via ZRender events (
zr:mousemove/zr:globalout). - After each dataset update, reset the axis pointer state and re-show the tip at the stored mouse coordinates.
| File | Description |
|---|---|
| src/components/widgets/thermals/ThermalChart.vue | Captures mouse coordinates and re-dispatches axis-pointer/tooltip actions after dataset updates to preserve highlight behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Pedro Lamas <pedrolamas@gmail.com>
|
Btw, I found this reported upstream as apache/echarts#20588, open since Dec 2024. The cause is the FIXME in |

Each data update calls
setOption, which clears the highlight the axis pointer put on each series. The symbols at the pointer vanish at the next update, within a second, and stay gone until the pointer moves to another sample. The axis pointer still records those samples as highlighted, so it never restores them itself. Its line also stays on the sample it last snapped to, so with the mouse still it scrolls away with the data.After each data update the chart now resets the axis pointer (
updateAxisPointerwithcurrTrigger: 'leave') and shows it again at the mouse position (showTip), so the symbols come back and the line snaps back to the sample nearest the mouse.Before (symbols disappear, axis drifts):
axis_pointer_before-github.mp4
After:
axis_pointer_after-github.mp4