Skip to content

Added warning against migration to built-in kotlin - #13634

Open
jesswrd wants to merge 3 commits into
flutter:mainfrom
jesswrd:migration-warning
Open

Added warning against migration to built-in kotlin#13634
jesswrd wants to merge 3 commits into
flutter:mainfrom
jesswrd:migration-warning

Conversation

@jesswrd

@jesswrd jesswrd commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Added warning against migrating to built-in kotlin if project does not currently use KGP.

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@jesswrd
jesswrd requested review from a team and sfshaza2 as code owners July 28, 2026 00:50

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds warning callouts to the Kotlin migration documentation to clarify that the migration is only relevant for projects already using the Kotlin Gradle Plugin (KGP). The reviewer suggested rephrasing these warnings across all three files to specify that the migration itself is what only applies to KGP-using projects, rather than the entire guide, which resolves contradictions and ensures accuracy.

@flutter-website-bot

flutter-website-bot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated docs.flutter.dev site (updated for commit 2026164):

https://flutter-docs-prod--docs-pr13634-migration-warning-1du7aw2r.web.app

@flutter-website-bot

flutter-website-bot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Staged preview of the updated flutter.dev site (updated for commit 2026164):

https://flutter-dev-230821--www-pr13634-migration-warning-ug8ucv7l.web.app

@liamappelbe

Copy link
Copy Markdown

Can the warning also mention what it means to "apply KGP"? Something like "If your project doesn't currently apply KGP (ie your gradle file doesn't have a line like apply plugin: 'kotlin-android'), ...".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants