Skip to content

Token key passed as parameter in customClasses #261

Description

@vipulvkp

value of token key passed under customClasses for Tokenizer is being used as the className for Token component and also for the tag that renders with a close action.

This is wrong . same class name will be used for both parent and child which screws up the design.
Please separate them.

https://github.com/fmoo/react-typeahead/blob/master/src/tokenizer/token.js

https://github.com/wookiehangover/react-typeahead who has forked your original repo has hardcoded the className of
to typeahead-token-close in https://github.com/wookiehangover/react-typeahead/blob/master/src/tokenizer/token.js.

please make this change in your repo as well or accept the change through a PR.

Update: Raised a PR. #262

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions