Skip to content

STCLI-287 - Correct package-manager handling in workspace command. - #405

Merged
JohnC-80 merged 9 commits into
mainfrom
STCLI-287
Aug 31, 2026
Merged

STCLI-287 - Correct package-manager handling in workspace command.#405
JohnC-80 merged 9 commits into
mainfrom
STCLI-287

Conversation

@JohnC-80

Copy link
Copy Markdown
Contributor

STCLI-287

The workspace command has leftover yarn import and yarn.install usage - just needed conversion to the generic packageManager implementation.

@JohnC-80
JohnC-80 requested a review from a team as a code owner July 28, 2026 12:56
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 579dd0b. ± Comparison against base commit 69e427b.

♻️ This comment has been updated with latest results.

@zburke zburke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specific change looks good, and yet I want to reject the ticket on the principle that we should not support global installations of stripes-cli. Ah well; I guess that's a separate battle for a separate day.

I still see yarn references in a few places, e.g. lib/cli/global-dirs.js, lib/commands/platform/clean.js, lib/cli/context.js, and a few others. Do we want/need to clean these up in the scope of this ticket too?

@Dmytro-Melnyshyn

Copy link
Copy Markdown

@JohnC-80 Can this PR be merged?

Expanded description for workspace command failure resolution.
@sonarqubecloud

Copy link
Copy Markdown

@JohnC-80
JohnC-80 merged commit b0a078d into main Aug 31, 2026
16 checks passed
@JohnC-80
JohnC-80 deleted the STCLI-287 branch August 31, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants