Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly passing a nullable filesystem option currently breaks both
to_dict()andto_json():The recursive pre-serialization pass sends
Noneto the encoder's unsupported-object handler. Preserve it alongside the other JSON primitives so it is represented asnullin JSON and remainsNonein the dictionary form.The regression tests cover positional arguments, keyword options, nested lists and mappings, exact serialized output, round trips, unchanged constructor state, and a real
HTTPFileSystemconfiguration.Validation
Linux, CPython 3.12.14, upstream
94afb3f6e99d1b74dffb58811f8a06fb7c27ed27:python -m pytest fsspec/tests/test_spec.py -q --benchmark-disable: 388 passed, 10 skipped, 1 xfailed.python -m pytest fsspec -q --benchmark-disable --maxfail=8: 2220 passed, 196 skipped, 2 xfailed, 2 failed. The two failures also reproduce on an unmodified checkout of the same upstream commit:test_processes[forkserver]cannot create an AF_UNIX socket in this environment, andtest_async_cat_file_rangescannot resolve the external NOAA S3 hostname.git diff --checkpass.