Repository navigation
Fix POST method in Pyodide HTTP session shim - #2270
Merged
martindurant merged 3 commits intoOct 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestsSessionShim.post()forwardsPOST}torequest(), which passes it toXMLHttpRequest.open(). Remove the stray brace.Add a parameterized wrapper regression for all six methods, including URL, options and return-value forwarding. On unmodified master the POST case fails and the other five pass; with this fix the synchronous HTTP test module passes all 49 tests on native Windows CPython 3.14.3. Changelog included.
The regression captures the
request()boundary; it does not execute a browser/Pyodide runtime or claim XHR integration coverage. AI-assisted and independently reproduced. Related open PR #960 adds a separate asynchronous JS filesystem; its diff does not cover this synchronous method typo.