Skip to content

fix: Event waiter mailbox growth on busy channels - #88

Merged
ftes merged 1 commit into
mainfrom
fix/event-waiter-mailbox
Sep 15, 2026
Merged

ftes merged 1 commit into
mainfrom
fix/event-waiter-mailbox

Conversation

@ftes

@ftes ftes commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Event waiters retained unrelated protocol events for their subscribed channel. A waiter using timeout: :infinity could accumulate those messages indefinitely.

Discard unrelated events and check the original deadline before receiving again, so queued traffic cannot postpone an expired timeout. Add regression coverage for mailbox draining, independent subscribers, and timeout enforcement, plus module documentation and a changelog entry.

Addresses the review comment on #87.

Validation

  • Both new regression tests failed before the fix and pass afterward.
  • mix check: formatting, Credo, compilation, Dialyzer, and all 211 tests passed.
  • All 211 tests passed over WebSocket using a local Playwright server; Docker was unavailable for the container-based runner.
  • mix docs --warnings-as-errors passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T08:22:38.543576Z ed29491 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ftes ftes changed the title Fix event waiter mailbox growth on busy channels fix: Event waiter mailbox growth on busy channels Sep 15, 2026
@ftes
ftes merged commit c211de9 into main Sep 15, 2026
3 checks passed
@ftes ftes mentioned this pull request Sep 15, 2026
@ftes
ftes deleted the fix/event-waiter-mailbox branch September 15, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant