Repository navigation
Fix relative package dirs and spaces in paths - #388
Merged
Merged
Conversation
AutoDocExtractExamples resolved the makedoc script against the package directory before changing into it, so a relative package directory, as given by 'gap --packagedirs .', made the script unreadable. The error also left the working directory changed, breaking later test files. The Makefile derived PKGDIR with make functions that split on spaces, so 'make check' and the other targets failed in such a directory. Assisted-by: Generative AI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
=======================================
Coverage 93.03% 93.04%
=======================================
Files 15 15
Lines 3132 3135 +3
=======================================
+ Hits 2914 2917 +3
Misses 218 218
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoDocExtractExamples resolved the makedoc script against the package
directory before changing into it, so a relative package directory, as
given by 'gap --packagedirs .', made the script unreadable. The error
also left the working directory changed, breaking later test files.
The Makefile derived PKGDIR with make functions that split on spaces,
so 'make check' and the other targets failed in such a directory.
Assisted-by: Generative AI