Repository navigation
Conversation
ConvertToVectorRep(v, q) for a GF(2) vector v, and CopyToVectorRep(v, q)
for a GF(2) or GF(q0) vector v, with GF(q) a larger field, took the
generic path, which inspects every entry in GAP code. The kernel
rewrites such vectors directly.
Setup:
gap> L:= List(IdentityMat(600, GF(2)), ShallowCopy);;
Before:
gap> M:= List(L, v -> CopyToVectorRep(v, 4));; time;
100
gap> M:= List(M, v -> CopyToVectorRep(v, 16));; time;
92
gap> for v in L do ConvertToVectorRep(v, 4); od; time;
99
After:
gap> M:= List(L, v -> CopyToVectorRep(v, 4));; time;
2
gap> M:= List(M, v -> CopyToVectorRep(v, 16));; time;
1
gap> for v in L do ConvertToVectorRep(v, 4); od; time;
1
Assisted-by: Generative AI
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6817 +/- ##
==========================================
+ Coverage 79.90% 79.93% +0.03%
==========================================
Files 685 685
Lines 295909 296036 +127
Branches 8696 8672 -24
==========================================
+ Hits 236432 236628 +196
+ Misses 57664 57594 -70
- Partials 1813 1814 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HPC-GAP reads its own copy of vecmat.gi, so apply the same fast paths there. Assisted-by: Generative AI
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertToVectorRep(v, q)for a GF(2) vector v, andCopyToVectorRep(v, q)for a GF(2) or GF(q0) vector v, with GF(q) a larger field, took the generic path, which inspects every entry in GAP code. The kernel rewrites such vectors directly.Setup:
Before:
After:
Assisted-by: Generative AI