Repository navigation
Conversation
ConvertToVectorRep(v, 1) and CopyToVectorRep(v, 1) could pass the field check, since 1 is the zeroth power of every field size, and handed q = 1 to the kernel, which crashed. They now raise an error. Assisted-by: Generative AI
fingolfin
added
kind: bug
Apply the fix for ConvertToVectorRep(v, 1) and CopyToVectorRep(v, 1) to the HPC-GAP copy of vecmat.gi as well. Assisted-by: Generative AI
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #6825 +/- ##
==========================================
- Coverage 79.94% 71.48% -8.47%
==========================================
Files 685 681 -4
Lines 295944 294746 -1198
Branches 8672 8679 +7
==========================================
- Hits 236599 210699 -25900
- Misses 57533 82110 +24577
- Partials 1812 1937 +125 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ThomasBreuer
approved these changes
Nov 11, 2026
ThomasBreuer
left a comment
ThomasBreuer
left a comment
Contributor
There was a problem hiding this comment.
Funny. Thanks.
(The documentation of LogInt says that the result is a positive integer.
Should we say that 0 is returned for n = 1, or should the input n = 1 better be forbidden?)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertToVectorRep(v, 1)andCopyToVectorRep(v, 1)could pass the field check, since 1 is the zeroth power of every field size, and handed q = 1 to the kernel, which crashed. They now raise an error.Assisted-by: Generative AI