Add ipv6 support overview - #1020
Conversation
|
Warning Review limit reached
Next review available in: 3 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for gardener-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@kevin-lacoo Could you have a look at the alicloud section, please? |
|
@DockToFuture: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
BoHristova
left a comment
There was a problem hiding this comment.
Thank you for the great overview!
I've suggested fixes for some of the links, as the current ones will break when the website is deployed. For pages that are pulled into the website via Docforge, we need to use GitHub links (see the Formatting Guide). The Netlify deploy preview is quite useful if you want to check whether the links work as expected.
|
@BoHristova Thanks for your review! |
|
@axel7born Thanks for applying the suggestions so quickly! I'll wait for @kevin-lacoo's review before approving the PR. /lgtm |
|
LGTM label has been added. DetailsGit tree hash: 35f2e51e8671bc7d47554900e9fdedc44d3d37e2 |
|
Hi @kevin-lacoo, could you please take a look at this PR (see previous comment)? Thank you :) |
|
|
||
| ### Migration | ||
|
|
||
| Add `dualStack.enabled: true` to `InfrastructureConfig` and add `IPv6` to `spec.networking.ipFamilies`. The infrastructure will be reconciled to enable IPv6 on the VPC and assign `/64` CIDRs to each zone's VSwitch. |
There was a problem hiding this comment.
| Add `dualStack.enabled: true` to `InfrastructureConfig` and add `IPv6` to `spec.networking.ipFamilies`. The infrastructure will be reconciled to enable IPv6 on the VPC and assign `/64` CIDRs to each zone's VSwitch. | |
| Add `dualStack.enabled: true` to `InfrastructureConfig`. The infrastructure will be reconciled to enable IPv6 on the VPC and assign `/64` CIDRs to each zone's VSwitch. |
| metadata: | ||
| annotations: | ||
| service.beta.kubernetes.io/alibaba-cloud-loadbalancer-ip-version: "DualStack" | ||
| service.beta.kubernetes.io/alibaba-cloud-loadbalancer-zone-maps: "<zone-a>:<vswitch-id-a>,<zone-b>:<vswitch-id-b>" |
There was a problem hiding this comment.
By default, the IPv6 addresses of Dual-Stack services created by Alibaba Cloud CCM only support internal access. To enable external Internet access via IPv6, add the following annotation to your Service manifest: service.beta.kubernetes.io/alibaba-cloud-loadbalancer-ipv6-address-type: internet
Sorry for later reply, I've given some comments above, thanks. |
from gcp requierments
Co-authored-by: Bozhidara Hristova <121290012+BoHristova@users.noreply.github.com>
Signed-off-by: Bozhidara Hristova <bozhidara.hristova@sap.com>
Signed-off-by: Bozhidara Hristova <bozhidara.hristova@sap.com>
394ab52 to
e571bbc
Compare
|
Hi @axel7born, @kevin-lacoo. I'm sorry that it took so long to apply the suggestions. I also moved the file to the new content directory (there was a content migration from When you have the time, could you take a quick look? If everything looks good, we can finally merge it :) |
|
/lgtm |
|
@kevin-lacoo: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BoHristova, DockToFuture The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 9459b3f221f4bd23091b324f3a8d7c40f06d55b8 |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: