Skip to content

[Backport 2026.02.xx] #12666 Identify: It sometimes select an empty option in the layer selector - #12780

Closed
offtherailz wants to merge 1 commit into
2026.02.xxfrom
backport-12736-to-2026.02.xx
Closed

[Backport 2026.02.xx] #12666 Identify: It sometimes select an empty option in the layer selector #12780
offtherailz wants to merge 1 commit into
2026.02.xxfrom
backport-12736-to-2026.02.xx

Conversation

@offtherailz

@offtherailz offtherailz commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

Backport of #12736 to 2026.02.xx.

Fixes #12666

@Binabh @github-actions
#12666 Identify: It sometimes select an empty option in the layer sel…
df38f04 
…ector (#12736)

Fix #12666 Identify: It sometimes select an empty option in the layer selector  (#12736)

(cherry picked from commit 2083f60)
@offtherailz offtherailz added this to the 2026.02.01 milestone Aug 7, 2026
@cla-bot cla-bot Bot added the CLA Ready label Aug 7, 2026
@offtherailz
offtherailz enabled auto-merge (squash) August 7, 2026 12:28
@offtherailz offtherailz mentioned this pull request Aug 7, 2026
Merged
4 of 6 tasks
@tdipisa tdipisa linked an issue Aug 10, 2026 that may be closed by this pull request
Identify: It sometimes select an empty option in the layer selector #12666
Open
1 task done
@tdipisa tdipisa assigned tdipisa and unassigned stefanocudini Aug 10, 2026
tdipisa
tdipisa requested changes Aug 10, 2026
View reviewed changes

@tdipisa tdipisa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Binabh please check failing checks.

@Binabh

Binabh commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

This is happening because failing tests in mapInfo-test.js expect different response structure. This was introduced by #12664 . If we change to satisfy tests here then it would break in master.
@tdipisa is there any plan to Backport #12664 ? If yes, then this need to be backported after #12664

@tdipisa

tdipisa commented Aug 10, 2026

Copy link
Copy Markdown
Member

@tdipisa is there any plan to Backport #12664 ? If yes, then this need to be backported after #12664

@Binabh #12664 is expected for 2026.03 series so no backport for that to 2026.02. Can a dedicated fix be very quickly provided for 2026.02.xx? Otherwise we will move #12666 to milestone 2026.03.00.

@tdipisa

tdipisa commented Aug 10, 2026

Copy link
Copy Markdown
Member

Closing as a quick backport is not applicable for 2026.02 series.

@tdipisa tdipisa closed this Aug 10, 2026
auto-merge was automatically disabled August 10, 2026 10:30

Pull request was closed

@tdipisa tdipisa removed this from the 2026.02.01 milestone Aug 10, 2026
@tdipisa tdipisa removed a link to an issue Aug 10, 2026
Identify: It sometimes select an empty option in the layer selector #12666
Open
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdipisa tdipisa tdipisa requested changes

Assignees

@tdipisa tdipisa

Labels

Backport CLA Ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@offtherailz @Binabh @tdipisa @stefanocudini