fix(menubar): launch the Windows tray exe by its real binary name - #1225
Closed
iamtoruk wants to merge 1 commit into
Closed
fix(menubar): launch the Windows tray exe by its real binary name#1225iamtoruk wants to merge 1 commit into
iamtoruk wants to merge 1 commit into
Conversation
The MSI installs codeburn-menubar.exe (Tauri names the binary after the crate), but the CLI joined InstallLocation with the product name and tried to spawn 'CodeBurn Menubar.exe', so 'codeburn menubar' installed the app and then failed to launch it (spawn ENOENT). Found on the first run on a real Windows 11 machine.
Member
Author
|
Superseded by #1228, which landed the same fix. The tray binary is now named by its own constant rather than derived from the product name ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First run of
codeburn menubaron a real Windows 11 install: the MSI installs fine, but the launch step fails with spawn ENOENT.Cause:
parseInstalledWindowsMenubarbuilds the exe path asInstallLocation + 'CodeBurn Menubar.exe'(the product name), while Tauri names the binary after the crate:codeburn-menubar.exe(windows/src-tauri/Cargo.toml). Verified in the guest:C:\Program Files\CodeBurn Menubar\codeburn-menubar.exeis the only exe the MSI ships, and launching it directly works.Fix: join with a
WINDOWS_EXE_NAMEconstant instead. The DisplayIcon fallback path is unchanged. Test fixtures updated to the real name.