fix(menubar): keep the wordmark filled under the shimmer and slow the sweep - #1240
Merged
Conversation
… sweep The letters were only visible through the animated gradient's mask, so any frame where the mask or gradient was not laid out yet blanked the name at random. The text now carries a static flame fill under the sweep, which can only brighten it, and the sweep runs 4 s each way instead of 1.5 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CodeBurn wordmark in the popover header vanished at random. The text was drawn hidden and only became visible through an animated gradient masked by the letters, so any frame where the mask or the gradient frame was not laid out yet (first frame after opening, animation retargeting on reopen) left nothing to show.
Fix: the letters keep a static flame gradient fill of their own, and the sweep is an overlay that can only brighten them. The sweep slows from 1.5 s to 4 s each way. Visibility gating on the popover (the idle CPU fix) is unchanged.
Tests: swift test 378 pass.