Skip to content

chore: keep real people and machines out of a public repository - #1250

Merged
iamtoruk merged 1 commit into
mainfrom
chore/scrub-personal-fixtures
Sep 3, 2026
Merged

chore: keep real people and machines out of a public repository#1250
iamtoruk merged 1 commit into
mainfrom
chore/scrub-personal-fixtures

Conversation

@iamtoruk

@iamtoruk iamtoruk commented Sep 3, 2026

Copy link
Copy Markdown
Member

Audit of everything on main since v0.9.23 — 252 commits, 323 files, ~41k added lines — for personal, customer, employer or infrastructure exposure. Three independent passes plus a mechanical sweep of every added line.

Clean across the whole range: no email addresses in content, no key/token/password-shaped strings, no server address or paths, no Cognito or account identifiers, no internal or staging hosts, no customer or employer reference, no committed logs, caches, exports or .env files. New network destinations are all first-party provider APIs, each receiving only that provider's own token. The telemetry snapshot holds its approved scope, verified by planted canaries asserting that project names, branches, paths and prose never reach it. assets/capacity-dock.jpg was opened and its EXIF checked: no GPS, no device, no timestamp.

Five places used a real value where an invented one would do. None is a credential; none identifies a customer.

Where What
perf/README.md:18 absolute path into a contributor's private audit workspace, cited as evidence no reader can open
perf/README.md:12 "Founder corpus (35 GB)" — a personal fact about one identifiable person
tests/live-sessions.test.ts a private product name as a fixture working directory
tests/sessions-report.test.ts, app/renderer/sections/Sessions.test.tsx the maintainer's real OS username, inside the tests that assert such paths are redacted
app/renderer/sections/Settings.test.tsx, app/renderer/App.test.tsx two real machine names, and the username again in a telemetry canary

The measurement in perf/README.md is kept; only its unopenable local path goes, replaced by a sentence saying the artifact is not published. Every fixture change is a rename — no assertion is weakened, and the redaction tests read better when the scrubbed string is obviously synthetic.

Tests: 22 CLI, 102 desktop, all passing.

Not changed, for the record. The maintainer's name in the About footer is a deliberate copyright line. The marketing screenshot is genuinely their own screen but shows only a $3.88 daily spend, quota percentages, a plan tier and a clock. Their personal email appears as a commit author in history from April onward, long predating this range. And the two files committed by mistake earlier today were removed from the tree in 10159d1d but remain in history.

An audit of everything on main since v0.9.23 turned up five places where
real detail had been used where an invented value would have done. None of
them is a credential and none identifies a customer, but a public
repository is the wrong home for any of it.

perf/README.md cited an absolute path into a private audit workspace on a
contributor's own machine, naming their home directory, the workspace's
naming scheme and a run timestamp accurate to the second, as "evidence" no
reader can open. The number stays; the path goes, and the text now says
plainly that the artifact is not published. The same file described the
measurement corpus as the founder's 35 GB of session history, which is a
personal fact about one identifiable person, so it is now described by what
it is rather than by whose it is.

The remaining three are fixtures: a private product name as a working
directory, the maintainer's real operating-system username inside the very
tests that assert such a path is redacted, and their two machine names in
the sharing tests. Using the real values proved nothing the invented ones do
not, and the redaction tests read better when the string being scrubbed is
obviously synthetic.
@iamtoruk
iamtoruk merged commit be8dfb8 into main Sep 3, 2026
12 checks passed
@iamtoruk
iamtoruk deleted the chore/scrub-personal-fixtures branch September 3, 2026 20:09
timothybrush pushed a commit to timothybrush/codeburn that referenced this pull request Sep 4, 2026
…g; finish the fixture scrub

An omitted creditUsagePercent inside an open billing window was read as 0%
for every Grok account. That contract only holds for unified-billing users;
for anyone else it now stays unknown instead of showing a fabricated 0%.

The wireframe mockup still carried the one device name getagentseal#1250 replaced
everywhere else.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant