Repository navigation
Bump radiance: stop leaking Soar streams - #9203
Conversation
radiance 5bff222 brings soar v0.2.4 and kindling 48c13b1 (getlantern/radiance#700). A round tripper that lost a race kept its Soar stream open, so a client that kept losing short races eventually failed every Soar attempt with "soar: too many streams" until restart. The range also brings getlantern/radiance#698 (peer helper direct mode). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QQFpfCXs3JqrfyDuiGabF5
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
🔵 Needs a closer look
The bundled peer-authentication, credential-rotation, and heartbeat reconciliation changes warrant human review despite no concrete defects being identified.
No open issues 🎉
What changed in this PR
Updates Lantern’s Go dependencies to bring in fixes for leaked Soar streams that could disable Soar until the client restarted. The Radiance update also includes peer-helper direct-mode changes.
Changes:
- Bumps Radiance from
25c0a61to5bff222, including peer pairing, rotation, and heartbeat reconciliation updates. - Updates Soar to
v0.2.4and Kindling to48c13b1to release unused streams and connections. - Refreshes the corresponding dependency checksums.
| File | Description |
|---|---|
| go.sum | Updates checksums for Radiance, Kindling, and Soar. |
| go.mod | Pins the updated Radiance and indirect dependency versions. |
Review effort: Balanced
Summary
This bumps radiance to
5bff222, which brings soar v0.2.4 and kindling48c13b1(getlantern/radiance#700). Together they fix a stream leak that permanently broke Soar on a long-running client.What happened on 10.0.3-beta-10: one Windows client failed every Soar attempt about 1,800 times over two days with
soar: too many streams.The fix has two halves, either of which stops the leak alone:
The new
vcs.ref.head.revisionattribute (#9183) is what pinned this to beta 10 and to one device. Once this ships, it will show whether that device and the rest of the fleet recover.Changes
github.com/getlantern/radiance25c0a61→5bff222. The range has two PRs:serve_poolin register and heartbeat, and rotation and heartbeat reconciliation.soarv0.2.3 → v0.2.4, andkindling0f4a89d→48c13b1.Only
go.modandgo.sumchange, aftergo mod tidy.Verification
go build ./...passes.CGO_ENABLED=1 go test -tags with_gvisor,with_quic,with_wireguard,with_utls,with_grpc ./...passes. These are CI's flags.Pre-PR review (local Codex gate)
CODEX GATE: verdict=approve critical=0 important=0 minor=0 reviewed=32approve. Besides the diff, the reviewer read:core.go,init_desktop.goandinit_mobile.go;🤖 Generated with Claude Code
https://claude.ai/code/session_01QQFpfCXs3JqrfyDuiGabF5
Summary by CodeRabbit