Skip to content

fix(attributes): Apply consistent scrubbing across deprecations - #692

Open
mjq wants to merge 1 commit into
mainfrom
mjq/deprecation-inconsistency
Open

mjq wants to merge 1 commit into
mainfrom
mjq/deprecation-inconsistency

Conversation

@mjq

@mjq mjq commented Oct 9, 2026

Copy link
Copy Markdown
Member

Description

Apply the same scrubbing rules across entire deprecation chains. This keeps the scrubbing behaviour predictable whether or not Relay is doing attribute rewriting. It also make semantic sense - if two attributes have identical semantic meanings, they should also have identical scrubbing rules.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

@vercel

vercel Bot commented Oct 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
sentry-conventions Ready Ready Preview Oct 9, 2026 2:28pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add integrity policy attributes by loewenheim in #691
  • Deprecate legacy MCP tool result fields by betegon in #689
  • Align MCP conventions and OAuth client identity by betegon in #671
  • Add AWS service instrumentation attributes by pabloDeputter in #672
  • Add gen_ai memory conventions by ArthurKnaus in #653

Other

  • (model) Add metric model by giortzisg in #649
  • Add enum_values entries to shorten attribute briefs by alexander-alderman-webb in #685

Bug Fixes 🐛

Attributes

  • Apply consistent scrubbing across deprecations by mjq in #692
  • Add search_alias to sentry.link.type attribute by Lms24 in #687
  • Remove any as valid attribute type by Lms24 in #677

Documentation 📚

  • (contributing) Document process for fixing a misnamed attribute by sentry-junior in #673

Internal Changes 🔧

Deps

  • Bump sharp from 0.35.4 to 0.35.5 by dependabot in #683
  • Bump source-map-js from 1.2.1 to 1.2.2 by dependabot in #675
  • Bump smol-toml from 1.8.0 to 1.9.0 by dependabot in #674
  • Bump postcss-selector-parser from 7.1.4 to 7.1.6 by dependabot in #676

Other

  • (deps-dev) Bump oxfmt to 0.72.0 to pull in patched tinypool by Lms24 in #682
  • (docs) Add link preview meta tags by Lms24 in #667
  • (publish) Stop npm version from rewriting yarn.lock by Lms24 in #678
  • Add "evaluate" as a well-known value for gen_ai.operation.name by alexander-alderman-webb in #680
  • Deprecate mcp.tool.result.content_count by alexander-alderman-webb in #669

🤖 This preview updates automatically when you update the PR.

@linear-code

linear-code Bot commented Oct 9, 2026

Copy link
Copy Markdown

EXP-1275

This branch was successfully deployed

1 active deployment
Preview — 2e972789 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant