Repository navigation
chore: Deprecate gen_ai.responses in favor of gen_ai.chat - #703
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gen_ai.responses, deprecated in favor of gen_ai.chatgen_ai.responses in favor of gen_ai.chat
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
fa6e002 to
bf1a6d4
Compare
| "description": "An interaction with a generative AI model through a responses API" | ||
| "description": "An interaction with a generative AI model through a responses API", | ||
| "deprecation": { | ||
| "replacement": "gen_ai.chat" |
There was a problem hiding this comment.
l: would make sense to add a "note" to the deprecation in this case, since it's not super obvious. wdyt?
There was a problem hiding this comment.
yes added a note.
It's unfortunate that we have this invariant (op is gen_ai.* + gen_ai.operation.name) but never enforce it.
we could probably add a test for this, wdyt? |
3c0ea3f to
dca2d99
Compare
|
I wrote a test that encodes: every Unfortunately, the test fails. I created an issue to track: #709 |
Description
For GenAI spans, the op is
gen_ai.appended with the value of thegen_ai.operation.nameattribute.The
responsesliteral was never a valid value forgen_ai.operation.nameper OTel and our docs.PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)If an attribute was deprecated: