Repository navigation
Conversation
JPeer264
added this pull request to stack #25002
October 2, 2026 13:14
Contributor
size-limit report 📦
|
JPeer264
removed this pull request from stack #25002
October 2, 2026 13:31
JPeer264
changed the base branch from
jp/flue-map-messages-conventions
to
jp/bun-conversation-id-integration
October 2, 2026 13:39
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 2, 2026 13:39
1dad424 to
91a0b35
Compare
JPeer264
added this pull request to stack #25004
October 2, 2026 13:57
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 2, 2026 16:59
91a0b35 to
26d39c9
Compare
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 3, 2026 16:23
26d39c9 to
4fc5960
Compare
JPeer264
removed this pull request from stack #25004
October 5, 2026 07:21
JPeer264
added this pull request to stack #25029
October 5, 2026 07:22
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 5, 2026 09:44
4fc5960 to
f8eb62c
Compare
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 5, 2026 11:22
f8eb62c to
c8a1208
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
1 issue from previous review remains unresolved.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c8a1208. Configure here.
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 5, 2026 12:53
c8a1208 to
189004f
Compare
JPeer264
marked this pull request as ready for review
October 5, 2026 13:24
JPeer264
requested review from
chargome and
s1gr1d
and removed request for
a team
October 5, 2026 13:24
JPeer264
requested review from
andreiborza,
isaacs and
mydea
and removed request for
isaacs and
mydea
October 5, 2026 13:24
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 6, 2026 07:08
189004f to
aa37def
Compare
pi-durable has no telemetry hooks, so `piDurableIntegration` wraps the `models` and `registry` passed to `Harness.open()`. Each run becomes its own `invoke_agent` trace with `chat` and `execute_tool` children, and a subagent run nests under the tool call that started it. Messages are mapped to the gen_ai conventions, and the system prompt and tools are read from pi-durable's positional system messages. Tool spans record the result the model receives. Failures pi-durable only reports, and task phases that throw, are captured. Throws of the built-in coding tools are not, because they report expected results to the model. On Cloudflare it also covers pi-durable in a Durable Object through the Agents SDK `PiHarness`, including requests that pi-ai sends through the Workers AI binding. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/pi-durable-instrumentation
branch
from
October 6, 2026 07:55
aa37def to
e779efc
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
andreiborza
reviewed
Oct 6, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Thanks for all this effort! A couple of points:
| ...(harnessOptions.registry ? { registry: own(instrumentRegistry(harnessOptions.registry, options, runs)) } : {}), | ||
| // pi-durable passes failures of extension code here, such as a throwing hook, and keeps going. | ||
| onReport: own((error: unknown) => { | ||
| captureException(error, { mechanism: { handled: true, type: PI_DURABLE_ORIGIN } }); |
Member
There was a problem hiding this comment.
m: I'd make this dependent on if users set an onReport handler. If they did not, I don't think these errors should be classified as handled, wdyt?
Suggested change
| captureException(error, { mechanism: { handled: true, type: PI_DURABLE_ORIGIN } }); | |
| captureException(error, { mechanism: { handled: !!harnessOptions.onReport, type: PI_DURABLE_ORIGIN } }); |
| return startSpanManual( | ||
| { | ||
| name: model.id ? `chat ${model.id}` : 'chat', | ||
| op: getGenAiSpanOp('chat'), |
Member
There was a problem hiding this comment.
m: Use GEN_AI_CHAT from sentry conventions instead please.
| const startRunSpan = (): Span => | ||
| startInactiveSpan({ | ||
| name: 'invoke_agent', | ||
| op: getGenAiSpanOp('invoke_agent'), |
Member
There was a problem hiding this comment.
m: Replace with GEN_AI_INVOKE_AGENT please from sentry conventions.
| return startSpanManual( | ||
| { | ||
| name: `execute_tool ${tool.name}`, | ||
| op: getGenAiSpanOp('execute_tool'), |
Member
There was a problem hiding this comment.
m: Please us GEN_AI_EXECUTE_TOOL from sentry conventions instead.
Comment on lines
+149
to
+150
| if (!BUILT_IN_TOOLS.has(tool)) { | ||
| captureException(error, { mechanism: { handled: true, type: PI_DURABLE_ORIGIN } }); |
Member
There was a problem hiding this comment.
Suggested change
| if (!BUILT_IN_TOOLS.has(tool)) { | |
| captureException(error, { mechanism: { handled: true, type: PI_DURABLE_ORIGIN } }); | |
| if (!BUILT_IN_TOOLS.has(tool)) { | |
| captureException(error, { mechanism: { handled: false, type: PI_DURABLE_ORIGIN } }); |
m: Should be false here no? User has no chance to handle it?
Comment on lines
+401
to
+407
| expect(Object.keys(chat!)).not.toContain('gen_ai.input.messages'); | ||
| expect(Object.keys(chat!)).not.toContain('gen_ai.output.messages'); | ||
| expect(Object.keys(chat!)).not.toContain('gen_ai.system_instructions'); | ||
| expect(Object.keys(chat!)).not.toContain('gen_ai.tool.definitions'); | ||
| expect(Object.keys(execute!)).not.toContain('gen_ai.tool.call.arguments'); | ||
| expect(Object.keys(execute!)).not.toContain('gen_ai.tool.call.result'); | ||
| expect(execute!['gen_ai.tool.description']).toBe('Get the weather.'); |
Member
There was a problem hiding this comment.
l: Let's use constants from sentry conventions here too.
Comment on lines
+428
to
+433
| expect(recorded).not.toContain('gen_ai.input.messages'); | ||
| expect(recorded).not.toContain('gen_ai.output.messages'); | ||
| expect(recorded).not.toContain('gen_ai.system_instructions'); | ||
| expect(recorded).not.toContain('gen_ai.tool.definitions'); | ||
| expect(recorded).not.toContain('gen_ai.tool.call.arguments'); | ||
| expect(recorded).not.toContain('gen_ai.tool.call.result'); |
Member
There was a problem hiding this comment.
l: Let's use constants from sentry conventions here too.
Comment on lines
+549
to
+558
| expect(execute.attributes).toMatchObject({ | ||
| 'sentry.op': 'gen_ai.execute_tool', | ||
| 'sentry.origin': 'auto.ai.pi_durable', | ||
| 'gen_ai.tool.name': 'get_weather', | ||
| 'gen_ai.tool.description': 'Get the weather.', | ||
| 'gen_ai.tool.call.id': 'call_1', | ||
| 'gen_ai.conversation.id': `${runs.harnessId}:4`, | ||
| 'gen_ai.tool.call.arguments': '{"city":"Berlin"}', | ||
| 'gen_ai.tool.call.result': 'sunny', | ||
| }); |
Member
There was a problem hiding this comment.
l: Let's use constants from sentry conventions here too.
Comment on lines
+598
to
+601
| expect(errored!.attributes['sentry.status.message']).toBe('internal_error'); | ||
| expect(errored!.attributes['gen_ai.tool.call.result']).toBe('not found'); | ||
| expect(thrown!.attributes['sentry.status.message']).toBe('internal_error'); | ||
| expect(bash!.attributes['sentry.status.message']).toBe('internal_error'); |
Member
There was a problem hiding this comment.
l: Let's use constants from sentry conventions here too.
|
|
||
| - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott | ||
|
|
||
| - **feat(server-utils)**: The new `piDurableIntegration` traces runs of pi-durable and is on by default where the Sentry runtime hook or a Sentry bundler plugin injects its channel, for example in Node and in Workers built with `@sentry/cloudflare/vite`. From the first pi-durable model request on, the `openai`, `@anthropic-ai/sdk`, `@google/genai` and Workers AI integrations stop reporting requests in the whole process, because pi-ai sends its requests through these clients. Requests that your app sends to these providers directly are then no longer traced either. The Flue integration now also stops the Workers AI integration. To keep these integrations, remove the pi-durable one: `integrations: integrations => integrations.filter(integration => integration.name !== 'PiDurable')`. |
Member
There was a problem hiding this comment.
m: This entry is too technical. Just announce the integration and what it does (tracing Pi Durable).
Comment on lines
+179
to
+182
| } | ||
| if (message.isError && !call.failed) { | ||
| call.span.setStatus({ code: SPAN_STATUS_ERROR, message: 'internal_error' }); | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: The function piAiContentToString returns an empty string for undefined input, violating its string | undefined return type and causing an empty attribute to be set on spans.
Severity: LOW
Suggested Fix
Modify piAiContentToString to return undefined when its input is undefined. This can be done by adding a check at the beginning of the function, like if (content === undefined) { return undefined; }, to align its behavior with its type signature.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/server-utils/src/ai/pi-durable/tools.ts#L179-L182
Potential issue: The function `piAiContentToString` has a return type of `string |
undefined`, but it incorrectly returns an empty string (`''`) when the input `content`
is `undefined`. The calling function, `finishToolCall`, checks `if (result !==
undefined)` to decide whether to set a span attribute. Because `'' !== undefined` is
true, an empty string is set as the `GEN_AI_TOOL_CALL_RESULT` attribute on the span.
This is misleading, as it represents 'no content' as 'empty content' in telemetry,
instead of omitting the attribute altogether.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
piDurableIntegrationfor@earendil-works/pi-durable, Earendil's new durable agent harness. It is on by default in Node, Bun and Deno, and in a Worker built with@sentry/cloudflare/vite, which covers pi-durable in a Durable Object through the Agents SDKPiHarness. Each run becomes its owninvoke_agenttrace withchatandexecute_toolchildren, and the first run of a subagent conversation nests under the tool call that created it.pi-durable has no telemetry hooks (
pi-telemetryexists, but no pi package emits spans through it yet), so the integration hooksHarness.open()and wraps themodelsandregistryit receives. The wrapped options keep the caller's options as prototype, because pi-durable readssettings,envandconversationCreatedat every use.Decisions worth a look:
pi.generationtask after every tool round, so no single task spans a run. The run span ends when the commit that removespi.live.rungoes through, or when the Harness closes with the run in flight.@sentry/cloudflarebinds the client to the scope of each request, not to the default scope.gen_ai.conversation.idis<harness id>:<conversation id>. pi-durable numbers conversations per storage from 1, so the bare id would merge every root conversation into one. The cost is a new id after a restart (on Cloudflare, after every restart of the Durable Object), until pi-durable has a stable storage id.api.output()(all ofbash) and results anafterToolhook redacted.onReport(throwing hooks or sections) and task phases that throw are captured. Throws of the built-in coding tools are not, becausebashthrows for every non-zero exit, a normal result for a coding agent. The built-in tools are recognized by their factories (createBashTool()and friends), so an app that registers them in an extension of its own gets the same treatment. The span keeps its error status.openai,@anthropic-ai/sdkand@google/genaiclients, or through the Workers AI binding withcreateAI()ofagents/models/pi-ai, and those integrations cannot tell pi-ai's calls from the app's own. Bedrock requests go through the AWS SDK, whichawsIntegrationstill reports twice; that skip is a follow-up.Messages, token usage and finish reasons go through the pi-ai mapper from the Flue fix, and the system prompt and tools are replayed from pi-durable's positional system messages.
Not covered yet: spans for tool calls pi-durable answers without running
execute(), spans for custom tasks, agent names (pi-durable has none), a link between a run and the request that submitted it, a marker for compaction requests, and an error event for a failed model request (thechatspan carries the status).🤖 Generated with Claude Code