fix(browser-utils): Handle NS_ERROR_NOT_INITIALIZED from setTimeout in Firefox - #25024
Open
sentry[bot] wants to merge 2 commits into
Open
sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
…n Firefox Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f04354. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).This PR addresses an issue where
getNativeImplementation('setTimeout')could cause anNS_ERROR_NOT_INITIALIZEDerror in Firefox.Root Cause:
When
window.setTimeoutis wrapped (e.g., by a browser extension),@sentry/browser-utilsattempts to get a nativesetTimeoutimplementation by creating a hidden iframe, extractingsetTimeoutfrom itscontentWindow, and then immediately removing the iframe. If Replay'safterSendEventhook later calls this cachedsetTimeoutfunction, Firefox throwsNS_ERROR_NOT_INITIALIZEDbecause the function belongs to a detached window.Fix:
The
setTimeoutwrapper inpackages/browser-utils/src/getNativeImplementation.tsnow includes atry/catchblock. If calling the iframe-sourcedsetTimeoutthrows an error (likeNS_ERROR_NOT_INITIALIZED), it falls back towindow.setTimeoutand caches this fallback for subsequent calls. This ensures that even if the native implementation from the iframe fails, the SDK can still use a functionalsetTimeout.Regression Test:
A new test file,
packages/browser-utils/test/getNativeImplementation.test.ts, has been added. This test simulates the Firefox behavior by mocking a wrappedwindow.setTimeoutand an iframesetTimeoutthat throwsNS_ERROR_NOT_INITIALIZED, verifying that the fallback mechanism works as expected.Closes #issue_link_here
Fixes DOCS-BAX
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this run