Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry-junior[bot]](https://avatars.githubusercontent.com/in/2960336?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks good to me. linear.app/new with title/description matches Linear's documented prefill URL, and building the backlink from the finding UUID (without the dashboard's search params) gives the ticket a stable reference even when short IDs repeat. Since FindingArticle is shared, the inspector and the full page get the same draft, and the optional evidence, location, source, and commit lines drop out cleanly for older findings. The new app tests pass for me locally on this branch.
Contributor
There was a problem hiding this comment.
Nice, small addition. Linking the draft to the UUID page and leaving range out of it both look right, and the old-finding test covers the optional fields well. Two things to look at:
- In
linear-issue.tsx,- Source:usesdetail.sourceUrldirectly.FindingArticleonly renders it when it matches^https?://, and the schema'sz.url()doesn't enforce that. Pull that check into a small shared helper, likesafeSourceUrl(detail), and use it in both places. That way the ticket can't carry a link the dashboard itself refuses to render. - Worst case, the draft URL gets big. The description can be up to 8k chars and verification up to 4k, and URL-encoding inflates both, so a long finding can push
linear.app/new?...into the range where proxies start returning 414s. Consider capping the description/evidence in the draft (truncate with a "see Warden for full details" pointer, since the finding link is already there). If you do, add one test with a max-length finding.
gricha
force-pushed
the
codex/linear-finding-drafts
branch
from
October 10, 2026 06:03
fbd5efe to
d2529c3
Compare
gricha
force-pushed
the
codex/linear-finding-drafts
branch
from
October 10, 2026 06:34
d2529c3 to
620dd5e
Compare
gricha
added a commit
that referenced
this pull request
Oct 10, 2026
Replace dashboard DOM construction with strict TypeScript, React, and Effect. Keep the existing usage and finding views, filters, themes, and token controls. Effect validates service responses, handles failures, and cancels obsolete requests. Search typing survives delayed URL updates and still follows filter resets and browser history. Newly created token secrets stay visible during a failed list refresh, and account controls offer a retry after a request failure. React and React DOM are pinned together. Vite builds assets for the existing authenticated service routes. CI checks both TypeScript configurations and Oxlint, including hooks, accessibility, and unsafe values. Frontend requirements live in `policies/warden-service-frontend.md`, linked from the app and service `AGENTS.md` files. App and service integration tests cover navigation, stale responses, token creation, account recovery, and asset authentication. Lint, typecheck, build, and repository tests pass. Evidence (#545), short finding URLs (#546), and Linear drafts (#548) are separate follow-up PRs. --------- Co-authored-by: GPT-6 <noreply@anthropic.com>
gricha
force-pushed
the
codex/linear-finding-drafts
branch
from
October 10, 2026 06:45
620dd5e to
bbfd720
Compare
gricha
force-pushed
the
codex/linear-finding-drafts
branch
from
October 10, 2026 16:09
bbfd720 to
a4ee9a1
Compare
gricha
force-pushed
the
codex/linear-finding-drafts
branch
from
October 10, 2026 16:19
a4ee9a1 to
5e6b045
Compare
gricha
changed the title
gricha
force-pushed
the
codex/linear-finding-drafts
branch
from
October 10, 2026 16:55
5e6b045 to
8dc675f
Compare
Give each finding a permanent short URL and redirect existing UUID links. Keep repeated findings distinct so opening a short URL preserves the selected record, including after retention deletes older findings. Backfill existing records during deployment and keep the migration compatible with writes from the previous service version. Refs GH-546 Co-Authored-By: GPT-6 <noreply@anthropic.com>
Create tickets through the service with a configured Linear API key and team. Include retained evidence and source links, and show the ticket on later visits. Use the finding UUID in Linear so repeated requests reuse the same issue. Limit the action to browser users in the configured tenant with finding access. Co-Authored-By: GPT-6 <noreply@anthropic.com>
Keep the finding action hidden until the service responds, so deployments without Linear credentials do not briefly show a disabled button. Co-Authored-By: GPT-6 <noreply@anthropic.com>
Link tickets to the finding's permanent short URL. Keep the finding UUID as the Linear issue ID so retries still reuse the same ticket. Co-Authored-By: GPT-6 <noreply@anthropic.com>
gricha
force-pushed
the
codex/linear-finding-drafts
branch
from
October 10, 2026 20:30
378032d to
675fe31
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Linear issues from the finding inspector and full page, with the description, evidence, and source links. The button then links to the issue. Using the finding UUID as the Linear issue ID makes repeated clicks, retries, and lost responses reuse the same ticket.
Set
LINEAR_API_KEYandLINEAR_TEAM_IDin Vercel and redeploy. Leave both unset to keep the action hidden. The key stays on the server. Browser users in the configured tenant can create tickets for findings they can read; bearer tokens cannot use the action.Depends on #549. Ticket descriptions use the finding's permanent short URL.
Lint, strict typechecking, build, and tests pass. Integration tests mock Linear.