Try upgrading github/codeql dependency to 2.22.4 without merging next for performance testing - #1187
Closed
MichaelRFairhurst wants to merge 4 commits into
Closed
Try upgrading github/codeql dependency to 2.22.4 without merging next for performance testing#1187MichaelRFairhurst wants to merge 4 commits into
github/codeql dependency to 2.22.4 without merging next for performance testing#1187MichaelRFairhurst wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s supported CodeQL toolchain to CLI 2.22.4 for performance testing.
Changes:
- Updates CodeQL CLI, standard library, and bundle references.
- Upgrades
codeql/cpp-allto 5.4.1 and refreshes transitive locks. - A required release change note is missing.
Show a summary per file
| File | Description |
|---|---|
supported_codeql_configs.json |
Targets CodeQL 2.22.4. |
scripts/generate_modules/queries/qlpack.yml |
Upgrades cpp-all. |
scripts/generate_modules/queries/codeql-pack.lock.yml |
Refreshes locked dependencies. |
cpp/report/src/qlpack.yml |
Upgrades cpp-all. |
cpp/report/src/codeql-pack.lock.yml |
Refreshes report dependencies. |
cpp/misra/test/codeql-pack.lock.yml |
Refreshes MISRA C++ test dependencies. |
cpp/misra/src/qlpack.yml |
Upgrades cpp-all. |
cpp/misra/src/codeql-pack.lock.yml |
Refreshes MISRA C++ dependencies. |
cpp/common/test/codeql-pack.lock.yml |
Refreshes common C++ test dependencies. |
cpp/common/src/qlpack.yml |
Upgrades cpp-all. |
cpp/common/src/codeql-pack.lock.yml |
Refreshes common C++ dependencies. |
cpp/cert/test/codeql-pack.lock.yml |
Refreshes CERT C++ test dependencies. |
cpp/cert/src/qlpack.yml |
Upgrades cpp-all. |
cpp/cert/src/codeql-pack.lock.yml |
Refreshes CERT C++ dependencies. |
cpp/autosar/test/codeql-pack.lock.yml |
Refreshes AUTOSAR test dependencies. |
cpp/autosar/src/qlpack.yml |
Upgrades cpp-all. |
cpp/autosar/src/codeql-pack.lock.yml |
Refreshes AUTOSAR dependencies. |
c/misra/test/codeql-pack.lock.yml |
Refreshes MISRA C test dependencies. |
c/misra/src/qlpack.yml |
Upgrades cpp-all. |
c/misra/src/codeql-pack.lock.yml |
Refreshes MISRA C dependencies. |
c/common/test/codeql-pack.lock.yml |
Refreshes common C test dependencies. |
c/common/src/qlpack.yml |
Upgrades cpp-all. |
c/common/src/codeql-pack.lock.yml |
Refreshes common C dependencies. |
c/cert/test/codeql-pack.lock.yml |
Refreshes CERT C test dependencies. |
c/cert/src/qlpack.yml |
Upgrades cpp-all. |
c/cert/src/codeql-pack.lock.yml |
Refreshes CERT C dependencies. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 26/26 changed files
- Comments generated: 1
- Review effort level: Balanced
| "codeql_cli": "2.21.4", | ||
| "codeql_standard_library": "codeql-cli/v2.21.4", | ||
| "codeql_cli_bundle": "codeql-bundle-v2.21.4" | ||
| "codeql_cli": "2.22.4", |
Collaborator
Author
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
Collaborator
Author
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
Collaborator
Author
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
|
🏁 Beep Boop! Performance testing complete! See below for performance of the last 3 runs vs your PR. Times are based on predicate performance. You can find full graphs and stats in the PR that was created for this test in the release engineering repo. 🏁 Below are the slowest predicates for the last 2 releases vs this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.