Fix .NET GitHub telemetry forwarding

[roji]

Summary

• Send enableGitHubTelemetryForwarding during the connect handshake, which is where the runtime now negotiates forwarding.
• Harden the .NET GitHub telemetry E2E to drive a real replayed turn and wait for the notification belonging to the live session instead of peeking the first queued event.
• Add unit coverage that asserts the forwarding opt-in is present on connect, and add the replay snapshot used by the E2E.

Validation

• DOTNET_ROLL_FORWARD=Major dotnet test dotnet/test/GitHub.Copilot.SDK.Test.csproj -f net8.0 --filter "FullyQualifiedName~GitHubTelemetryTests|FullyQualifiedName~GitHubTelemetryForwardingE2ETests|FullyQualifiedName~RpcSessionStateExtrasE2ETests"
  • Passed locally (13/13).

[Copilot]

Pull request overview

Updates .NET E2E tests to align with recently generated RPC and telemetry types so the test project compiles and assertions match updated nullability.

Changes:

• Update SetAllowAllAsync calls to use the named enabled: argument (to avoid binding issues after an optional mode parameter was added).
• Update GitHub telemetry E2E assertion to be compatible with a nullable SessionId property type.

Show a summary per file

File	Description
dotnet/test/E2E/RpcSessionStateExtrasE2ETests.cs	Uses the named enabled: argument for SetAllowAllAsync to match the updated generated RPC signature.
dotnet/test/E2E/GitHubTelemetryForwardingE2ETests.cs	Adjusts the assertion for notification.SessionId to avoid nullable-type assertion issues.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Low

[github-actions]

Cross-SDK Consistency: enableGitHubTelemetryForwarding in connect handshake

This PR fixes the .NET SDK to send enableGitHubTelemetryForwarding in the connect handshake (where the runtime now negotiates telemetry forwarding). However, the other five SDK implementations still only send this flag in session.create and session.resume — they don't include it in the connect call.

Interestingly, the generated protocol types already have this field on ConnectRequest in all SDKs, so the fix in each one is a small, targeted addition.

Current state

SDK	In connect	In session.create	In session.resume
.NET (this PR)	✅	✅	✅
Node.js	❌	✅	✅
Python	❌	✅	✅
Go	❌	✅	✅
Java	❌	✅	✅
Rust	❌	✅	✅

Where to apply the equivalent fix

• Node.js – nodejs/src/client.ts — where the connect request is sent (currently only includes token); add enableGitHubTelemetryForwarding: true when this.onGitHubTelemetry != null. The generated ConnectRequest type in nodejs/src/generated/rpc.ts already has the field.

• Python – python/copilot/client.py, line 3307 — _ConnectRequest(token=self._effective_connection_token) → add enable_git_hub_telemetry_forwarding=True when self._on_github_telemetry is not None. The generated _ConnectRequest dataclass in python/copilot/generated/rpc.py already has the field.

• Go – go/client.go — in connectToServer, the rpc.ConnectRequest is built with only Token; add EnableGitHubTelemetryForwarding: Bool(true) when c.options.OnGitHubTelemetry != nil. The generated ConnectRequest struct in go/rpc/zrpc.go already has the field.

• Java – java/src/main/java/com/github/copilot/CopilotClient.java, verifyProtocolVersion method — new ConnectParams(effectiveConnectionToken) needs a field for enableGitHubTelemetryForwarding. The generated ConnectRequest class in java/src/generated/java/ already has the field (check getEnableGitHubTelemetryForwarding() / setEnableGitHubTelemetryForwarding()).

• Rust – rust/src/lib.rs, connect_handshake method, line 1823 — ConnectRequest { token: ... } → add enable_github_telemetry_forwarding: self.inner.on_github_telemetry.is_some().then_some(true). The generated ConnectRequest struct in rust/src/generated/api_types.rs already has the field.

Since the PR description states that the runtime now negotiates forwarding at the connect level, leaving the other SDKs unchanged would silently break GitHub telemetry forwarding for those SDK users after a runtime update.

Generated by SDK Consistency Review Agent for issue #1910 · sonnet46 1.9M · ◷