[Repo Assist] perf(logger): sanitize RPC payload once for text+markdown previews

[github-actions]

🤖 This is an automated pull request from Repo Assist, an AI assistant.

Summary

Each RPC message is logged in two preview formats — a text log (10 KB preview) and a markdown log (512-byte preview). Previously logRPCMessageToAll called newRPCMessageInfo twice, each of which called truncateAndSanitize → sanitize.SanitizeString. SanitizeString runs 10 compiled regexp.Regexp.ReplaceAllStringFunc calls over the full payload, so every RPC hop paid that cost twice.

Root Cause

Before: two full sanitization passes per RPC hop:

infoText     := newRPCMessageInfo(..., MaxPayloadPreviewLengthText)     // calls SanitizeString
infoMarkdown := newRPCMessageInfo(..., MaxPayloadPreviewLengthMarkdown) // calls SanitizeString again

Fix

• Added newRPCMessageInfoFromSanitized: builds RPCMessageInfo from an already-sanitized string, only truncating.
• Added truncateSanitized: thin wrapper over util.Truncate to signal "already sanitized, just truncate".
• Updated logRPCMessageToAll to call sanitize.SanitizeString once and share the result for both previews.
• Rewrote formatRPCMessage to use strings.Builder + strconv.Itoa instead of []string + append + strings.Join + fmt.Sprintf, eliminating the intermediate slice allocation.

After: one sanitization pass shared between both preview lengths:

sanitized    := sanitize.SanitizeString(string(payload))
infoText     := newRPCMessageInfoFromSanitized(..., sanitized, MaxPayloadPreviewLengthText)
infoMarkdown := newRPCMessageInfoFromSanitized(..., sanitized, MaxPayloadPreviewLengthMarkdown)

Trade-offs

• No behaviour change: output is identical.
• The sanitization contract is preserved — newRPCMessageInfoFromSanitized is only called from logRPCMessageToAll after an explicit sanitize.SanitizeString call.
• newRPCMessageInfo is retained for future callers that provide a raw payload.

Test Status

⚠️ Outbound network access to proxy.golang.org is blocked in this sandbox, preventing go test / make agent-finished from downloading module dependencies. The changes were reviewed for correctness against existing tests:

• TestFormatRPCMessage — exercises formatRPCMessage via RPCMessageInfo; builder-based rewrite produces identical output.
• TestLogRPCRequest, TestLogRPCResponse, TestLogRPCRequestWithSecrets, TestLogRPCRequestPayloadTruncation — exercise logRPCMessageToAll through the public API; behaviour is unchanged.
• TestTruncateAndSanitize — tests truncateAndSanitize which is unchanged.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by Repo Assist · 464.4 AIC · ⊞ 10.8K · ◷
_{Comment /repo-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55

[Copilot]

Pull request overview

This PR reduces per-RPC logging overhead in the internal/logger package by ensuring payload sanitization is performed once per message and reused across multiple preview formats, and by reducing allocations in the text RPC formatter.

Changes:

• Added a sanitized-payload path (newRPCMessageInfoFromSanitized + truncateSanitized) so text + markdown previews share the same sanitization work.
• Updated logRPCMessageToAll to sanitize once and then truncate to the two configured preview lengths.
• Rewrote formatRPCMessage to use strings.Builder + strconv.Itoa to avoid intermediate slice allocations.

Show a summary per file

File	Description
internal/logger/rpc_logger.go	Sanitizes RPC payload once and reuses it for text/markdown previews via a new helper constructor.
internal/logger/rpc_format.go	Adds truncateSanitized and optimizes formatRPCMessage to reduce allocations.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Low

[lpcox]

@copilot fix failing ci

[Copilot]

@copilot fix failing ci

Fixed in 0ee12ef. The CI failure was the unused linter flagging newRPCMessageInfo — the function was retained after the refactor but never called. Removed it.