fix(deps): resolve brace-expansion DoS advisory; scope audit to production deps - #20
Merged
Merged
Conversation
…ction deps All 17 high-severity npm audit findings collapsed to one advisory (GHSA-mh99-v99m-4gvg, brace-expansion DoS via unbounded expansion), reachable only through dev tooling (eslint's internals, fixturify-project/bintastic's test fixtures) — never through the published package's runtime dependencies. `npm audit fix` reported no fix available because the transitive dependents (minimatch, etc.) haven't bumped their own brace-expansion range to allow the fixed 5.0.8. Verified empirically that forcing it via the existing overrides mechanism (already used here for esbuild/undici/tmp) is safe: 5.0.8 ships dual CJS/ESM builds, so old `require("brace-expansion")` call sites still resolve to a callable function. Full gate (typecheck/lint/test/build/docs/pack) stays green, and it nets -19 installed packages by deduping what were separate 1.x/2.x copies. Since devDependencies never ship to consumers, a vulnerability there isn't a real risk and shouldn't gate releases or prompt overrides the way a production one does. Adds `npm run audit` (`npm audit --omit=dev`) as the going-forward convention, wired into CI, so production dependencies stay audit-clean without dev-tooling noise.
![glean-it[bot]](https://avatars.githubusercontent.com/u/48140418?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm auditfindings — they collapsed to one advisory (GHSA-mh99-v99m-4gvg, brace-expansion DoS), reachable only through dev tooling (eslint's internals,fixturify-project/bintastic's test fixtures), never through the published package's runtime dependencies.npm audit fixreports "no fix available" because transitive dependents (minimatch, etc.) haven't bumped their ownbrace-expansionrange to allow the fixed5.0.8yet. Verified empirically that forcing it via the existingoverridesmechanism (already used here foresbuild/undici/tmp) is safe:5.0.8ships dual CJS/ESM builds, so oldrequire("brace-expansion")call sites still resolve to a callable function. Nets -19 installed packages by deduping what were separate 1.x/2.x copies.npm run audit(npm audit --omit=dev) as the going-forward convention, wired into CI. Since devDependencies never ship to consumers, a vulnerability there isn't a real risk and shouldn't gate releases or prompt overrides the way a production one does — this scopes future scans accordingly instead of chasing dev-tooling noise.CLAUDE.md.Test plan
npm audit→ 0 vulnerabilities (was 17 high)npm run audit(new, production-only) → 0 vulnerabilitiesnpm run typechecknpm run lintnpm test(76/76)npm run buildnode dist/cli.js docs --checknpm pack --dry-run