Skip to content

Fix qualifier skipping for nil-message dispatch - #412

Closed
HendrikHuebner wants to merge 0 commit into
gnustep:masterfrom
HendrikHuebner:qualifier-bug
Closed

Fix qualifier skipping for nil-message dispatch#412
HendrikHuebner wants to merge 0 commit into
gnustep:masterfrom
HendrikHuebner:qualifier-bug

Conversation

@HendrikHuebner

Copy link
Copy Markdown

This PR fixes a bug in the message dispatch. We never actually skipped the qualifiers here.

	const char *t = selector->types;
	// Skip type qualifiers
	while ('r' == *t || 'n' == *t || 'N' == *t || 'o' == *t ||
			     'O' == *t || 'R' == *t || 'V' == *t || 'A' == *t) {
		t++;
	}

	switch (selector->types[0]) // t is unused
 i	{ ...

@davidchisnall davidchisnall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, bother, I think we fixed this in another place but not here.

@davidchisnall

Copy link
Copy Markdown
Member

Ah, no, we fixed it already.

@davidchisnall

Copy link
Copy Markdown
Member

(Rebasing turned this into a thing with no changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants