Repository navigation
Pass the chunk length to NewReader() when reading chunks. - #231
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1009621243
branch
3 times, most recently
from
November 20, 2026 13:02
a07b183 to
b13edbc
Compare
Chunk reads create a child reader with `NewReader(offset)` and read the chunk with `MaskedReader`. They now use `NewReader(offset, length_hint)` with the length being read, so that `riegeli::GcsReader` sends one request for exactly this range instead of an open-ended request which is cancelled after the chunk is read. Sources which do not use the hint, e.g. `FileReader`, `FdReader`, and `StringReader`, read as before. With `index_storage_option:offloaded`, each chunk offset lookup reads the footer chunk with `DefaultChunkReader`. Its length, measured when the footer is read by `Initialize()`, is passed too, so these lookups no longer send an open-ended request each which is cancelled before the footer padding and postscript are read. PiperOrigin-RevId: 1026412932
copybara-service
Bot
force-pushed
the
test_1009621243
branch
from
November 20, 2026 13:51
b13edbc to
0d7f050
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the chunk length to
NewReader()when reading chunks.Chunk reads create a child reader with
NewReader(offset)and read the chunkwith
MaskedReader. They now useNewReader(offset, length_hint)with thelength being read, so that
riegeli::GcsReadersends one request for exactlythis range instead of an open-ended request which is cancelled after the chunk
is read. Sources which do not use the hint, e.g.
FileReader,FdReader, andStringReader, read as before.With
index_storage_option:offloaded, each chunk offset lookup reads thefooter chunk with
DefaultChunkReader. Its length, measured when the footer isread by
Initialize(), is passed too, so these lookups no longer send anopen-ended request each which is cancelled before the footer padding and
postscript are read.