Repository navigation
Move ArrayRecord OSS builds to riegeli 0.0.0-20261117-64d553d and Bazel 8. - #236
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1025490093
branch
9 times, most recently
from
November 20, 2026 12:26
9ef044e to
594b513
Compare
…el 8.
The new riegeli release on BCR adds `Reader::NewReader(initial_pos, length_hint)`,
which upcoming ArrayRecord changes use for bounded GCS reads. Moving to it needs
several OSS build changes at once:
* The other direct dependencies in `MODULE.bazel` are raised to the versions
riegeli requires (abseil-cpp, protobuf, rules_cc, rules_python, platforms,
googletest, pybind11_bazel). The build sets
`--check_direct_dependencies=error`, so they must match.
* CI and the BCR presubmit move from Bazel 7 to Bazel 8: rules_python 2.4.1
does not load on Bazel 7.
* Linux wheels are built on `manylinux_2_28` instead of `manylinux2014`,
because Bazel 8 needs a newer libstdc++ than the manylinux2014 image has.
Prebuilt Linux wheels now need glibc 2.28 or newer, so CentOS/RHEL 7,
Amazon Linux 2, and Ubuntu 18.04 lose them. manylinux2014 is end-of-life
together with CentOS 7.
* `SequencedChunkWriter` pads with `WritePadding(kImplicitPadding)` in OSS
too, since the new riegeli removed `PadToBlockBoundary()`.
* macOS CI moves from `macos-14`, which GitHub Actions no longer runs for
this repository, to `macos-15`. `pypa/gh-action-pypi-publish` is pinned to
v1.14.3, which fixes GHSA-5xjx-3w67-w9x9.
* The wheel build skips the `*.venv` directories rules_python 2.x creates
for `py_test` targets. Their `python3` symlink does not resolve outside of
runfiles, and the macOS `rsync -L` fails on it.
`ArrayRecordReader` now uses insecure credentials for `gs://` paths when
`CLOUD_STORAGE_EMULATOR_ENDPOINT` is set. google-cloud-cpp 3.x documents this
for `storage::Client()`, but its default options replace these credentials with
Application Default Credentials. Outside of GCE those look up the metadata
server, and the read is retried until the retry policy expires. With the new
google-cloud-cpp, this made the GCS emulator tests in `array_record_module_test`
time out. This workaround can be removed once
googleapis/google-cloud-cpp#16678 is fixed (proposed
fix: googleapis/google-cloud-cpp#16687) and the OSS
build uses a google-cloud-cpp release with it.
PiperOrigin-RevId: 1026386371
copybara-service
Bot
force-pushed
the
test_1025490093
branch
from
November 20, 2026 12:54
594b513 to
2d1c9c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ArrayRecord OSS builds to riegeli 0.0.0-20261117-64d553d and Bazel 8.
The new riegeli release on BCR adds
Reader::NewReader(initial_pos, length_hint),which upcoming ArrayRecord changes use for bounded GCS reads. Moving to it needs
several OSS build changes at once:
MODULE.bazelare raised to the versionsriegeli requires (abseil-cpp, protobuf, rules_cc, rules_python, platforms,
googletest, pybind11_bazel). The build sets
--check_direct_dependencies=error, so they must match.does not load on Bazel 7.
manylinux_2_28instead ofmanylinux2014,because Bazel 8 needs a newer libstdc++ than the manylinux2014 image has.
Prebuilt Linux wheels now need glibc 2.28 or newer, so CentOS/RHEL 7,
Amazon Linux 2, and Ubuntu 18.04 lose them. manylinux2014 is end-of-life
together with CentOS 7.
SequencedChunkWriterpads withWritePadding(kImplicitPadding)in OSStoo, since the new riegeli removed
PadToBlockBoundary().macos-14, which GitHub Actions no longer runs forthis repository, to
macos-15.pypa/gh-action-pypi-publishis pinned tov1.14.3, which fixes GHSA-5xjx-3w67-w9x9.
*.venvdirectories rules_python 2.x createsfor
py_testtargets. Theirpython3symlink does not resolve outside ofrunfiles, and the macOS
rsync -Lfails on it.ArrayRecordReadernow uses insecure credentials forgs://paths whenCLOUD_STORAGE_EMULATOR_ENDPOINTis set. google-cloud-cpp 3.x documents thisfor
storage::Client(), but its default options replace these credentials withApplication Default Credentials. Outside of GCE those look up the metadata
server, and the read is retried until the retry policy expires. With the new
google-cloud-cpp, this made the GCS emulator tests in
array_record_module_testtime out. This workaround can be removed once
googleapis/google-cloud-cpp#16678 is fixed (proposed
fix: googleapis/google-cloud-cpp#16687) and the OSS
build uses a google-cloud-cpp release with it.