Skip to content

chore: migrate common libraries to std::optional#16254

Open
colinmoy wants to merge 7 commits into
googleapis:mainfrom
colinmoy:migrate-common-optional
Open

chore: migrate common libraries to std::optional#16254
colinmoy wants to merge 7 commits into
googleapis:mainfrom
colinmoy:migrate-common-optional

Conversation

@colinmoy

Copy link
Copy Markdown
Contributor

Replacing explicit usages of absl::optional with std::optional in the Common libraries and internal utilities (google/cloud/ and google/cloud/internal/) as part of broader modernization efforts

@colinmoy
colinmoy requested a review from a team as a code owner July 13, 2026 22:56

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the use of absl::optional, absl::nullopt, and absl::make_optional with their standard C++17 equivalents, std::optional, std::nullopt, and std::make_optional, across various files in the repository. It also updates the relevant #include directives and build dependencies accordingly. There are no review comments, and I have no feedback to provide.

@colinmoy
colinmoy force-pushed the migrate-common-optional branch 2 times, most recently from 6279111 to 148a765 Compare July 16, 2026 21:36
@colinmoy
colinmoy requested a review from a team as a code owner July 16, 2026 21:36
@colinmoy
colinmoy force-pushed the migrate-common-optional branch 2 times, most recently from f6f1543 to c6e493b Compare July 16, 2026 22:00
@colinmoy
colinmoy force-pushed the migrate-common-optional branch from 1b90f5b to 77222df Compare July 17, 2026 21:32
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.34703% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.29%. Comparing base (93c8274) to head (c926366).

Files with missing lines Patch % Lines
google/cloud/internal/curl_handle_factory.h 0.00% 4 Missing ⚠️
google/cloud/credentials.cc 50.00% 1 Missing ⚠️
...e/cloud/internal/async_read_write_stream_timeout.h 80.00% 1 Missing ⚠️
.../cloud/internal/async_streaming_read_rpc_timeout.h 80.00% 1 Missing ⚠️
...internal/openssl/parse_service_account_p12_file.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16254   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files        2221     2221           
  Lines      207359   207359           
=======================================
+ Hits       191372   191373    +1     
+ Misses      15987    15986    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@colinmoy
colinmoy force-pushed the migrate-common-optional branch from 199ab4b to 455b28d Compare July 20, 2026 17:30
@colinmoy
colinmoy force-pushed the migrate-common-optional branch from 455b28d to 6a88b12 Compare July 20, 2026 17:54
@colinmoy colinmoy closed this Jul 20, 2026
@colinmoy colinmoy reopened this Jul 20, 2026
@colinmoy
colinmoy force-pushed the migrate-common-optional branch 5 times, most recently from f51d18b to aac0c79 Compare July 21, 2026 18:01
@colinmoy
colinmoy force-pushed the migrate-common-optional branch from 329beb1 to 88cdba5 Compare July 21, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants