chore: migrate common libraries to std::optional#16254
Open
colinmoy wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the use of absl::optional, absl::nullopt, and absl::make_optional with their standard C++17 equivalents, std::optional, std::nullopt, and std::make_optional, across various files in the repository. It also updates the relevant #include directives and build dependencies accordingly. There are no review comments, and I have no feedback to provide.
colinmoy
force-pushed
the
migrate-common-optional
branch
2 times, most recently
from
July 16, 2026 21:36
6279111 to
148a765
Compare
colinmoy
force-pushed
the
migrate-common-optional
branch
2 times, most recently
from
July 16, 2026 22:00
f6f1543 to
c6e493b
Compare
colinmoy
force-pushed
the
migrate-common-optional
branch
from
July 17, 2026 21:32
1b90f5b to
77222df
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16254 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 2221 2221
Lines 207359 207359
=======================================
+ Hits 191372 191373 +1
+ Misses 15987 15986 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
approved these changes
Jul 20, 2026
colinmoy
force-pushed
the
migrate-common-optional
branch
from
July 20, 2026 17:30
199ab4b to
455b28d
Compare
colinmoy
force-pushed
the
migrate-common-optional
branch
from
July 20, 2026 17:54
455b28d to
6a88b12
Compare
colinmoy
force-pushed
the
migrate-common-optional
branch
5 times, most recently
from
July 21, 2026 18:01
f51d18b to
aac0c79
Compare
colinmoy
force-pushed
the
migrate-common-optional
branch
from
July 21, 2026 18:23
329beb1 to
88cdba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing explicit usages of absl::optional with std::optional in the Common libraries and internal utilities (google/cloud/ and google/cloud/internal/) as part of broader modernization efforts