ci(bigtable): add fake monitoring server and metric test that uses it#16266
Open
scotthart wants to merge 1 commit into
Open
ci(bigtable): add fake monitoring server and metric test that uses it#16266scotthart wants to merge 1 commit into
scotthart wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
api: bigtable
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an Observability Collector Server within the CI infrastructure to support end-to-end integration testing of OpenTelemetry metrics for Google Cloud C++ client libraries, starting with Bigtable. The changes include the server implementation, protobuf definitions for observability verification, and integration tests. My feedback includes a recommendation to refactor duplicated code in the server implementation to improve maintainability.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16266 +/- ##
==========================================
- Coverage 92.27% 92.27% -0.01%
==========================================
Files 2218 2218
Lines 206654 206665 +11
==========================================
- Hits 190699 190698 -1
- Misses 15955 15967 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
force-pushed
the
bigtable_ci_observability
branch
from
July 20, 2026 14:33
c8590cf to
876f2a8
Compare
scotthart
marked this pull request as ready for review
July 20, 2026 15:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a basic echo/replay server that implements the metrics service from Cloud Monitoring. The idea is to record the requests our exporter sends and then replay them back so their contents can be verified.