Skip to content

ci(bigtable): add fake monitoring server and metric test that uses it#16266

Draft
scotthart wants to merge 1 commit into
googleapis:mainfrom
scotthart:bigtable_ci_observability
Draft

ci(bigtable): add fake monitoring server and metric test that uses it#16266
scotthart wants to merge 1 commit into
googleapis:mainfrom
scotthart:bigtable_ci_observability

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Jul 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an Observability Collector Server within the CI infrastructure to support end-to-end integration testing of OpenTelemetry metrics for Google Cloud C++ client libraries, starting with Bigtable. The changes include the server implementation, protobuf definitions for observability verification, and integration tests. My feedback includes a recommendation to refactor duplicated code in the server implementation to improve maintainability.

Comment thread ci/otel_collector/otel_collector.cc
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.27%. Comparing base (40d3ab0) to head (c8590cf).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16266   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files        2214     2214           
  Lines      206505   206537   +32     
=======================================
+ Hits       190549   190579   +30     
- Misses      15956    15958    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart
scotthart force-pushed the bigtable_ci_observability branch from c8590cf to 876f2a8 Compare July 20, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant