fix(bigquery-jdbc): handle null parameters in Storage Write API bulk inserts - #14270
Open
Neenu1995 wants to merge 3 commits into
Open
fix(bigquery-jdbc): handle null parameters in Storage Write API bulk inserts#14270Neenu1995 wants to merge 3 commits into
Neenu1995 wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors JSON row creation in BigQueryPreparedStatement into a static helper method createJsonRow and adds support for handling null parameter values by mapping them to JsonNull.INSTANCE for the Storage Write API. It also includes corresponding unit and integration tests to verify batch inserts with null values. The reviewer suggested using the interface type List instead of the concrete implementation ArrayList in the signature of the new createJsonRow method to improve flexibility.
…c/BigQueryPreparedStatement.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14066