fix: turn on the gax vulnerability tests again - #9204
Conversation
…e-cloud-node into fix-dialog-flow
…e-cloud-node into fix-dialog-flow
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the core/packages/gax package to use @google-cloud/dialogflow-cx as a devDependency, replacing a relative require with an ES import. It also re-enables several transcoding validation tests (Test 1, Test 2, and Test 9) that were previously skipped. The feedback suggests removing the now-obsolete TODO comments associated with these re-enabled tests to keep the codebase clean.
|
|
||
| // Test 1: Single Asterisk Dot Validation on client call | ||
| it.skip('1. should throw an error for single-asterisk segment traversal using exactly "." as session ID', async () => { | ||
| it('1. should throw an error for single-asterisk segment traversal using exactly "." as session ID', async () => { |
There was a problem hiding this comment.
Since this test has been re-enabled, the TODO comment on the following line (// TODO: Re-enable this test when the gax version with the new encoding is released.) is now obsolete and should be removed to keep the codebase clean.
|
|
||
| // Test 2: Single Asterisk Dot-Dot Validation on client call | ||
| it.skip('2. should throw an error for single-asterisk segment traversal using exactly ".." as session ID', async () => { | ||
| it('2. should throw an error for single-asterisk segment traversal using exactly ".." as session ID', async () => { |
There was a problem hiding this comment.
Since this test has been re-enabled, the TODO comment on the following line (// TODO: Re-enable this test when the gax version with the new encoding is released.) is now obsolete and should be removed to keep the codebase clean.
|
|
||
| // Test 9: Percent-encoding all other characters | ||
| it.skip('9. should percent-encode all other characters except unreserved ones', async () => { | ||
| it('9. should percent-encode all other characters except unreserved ones', async () => { |
There was a problem hiding this comment.
Since this test has been re-enabled, the TODO comment on the following line (// TODO: Re-enable this test when the gax version with the new encoding is released.) is now obsolete and should be removed to keep the codebase clean.
|
We should address the linting separately so as not to block since this is needed for bun work. Backlogged in https://b.corp.google.com/issues/552061990. |
🤖 I have created a release *beep* *boop* --- <details><summary>common: 8.0.2</summary> ## [8.0.2](common-v8.0.1...common-v8.0.2) (2026-08-26) ### Bug Fixes * Patch the vulnerability for Bigquery and other REST based clients ([#9188](#9188)) ([94aac1e](94aac1e)) </details> <details><summary>google-gax: 6.1.0</summary> ## [6.1.0](google-gax-v6.0.3...google-gax-v6.1.0) (2026-08-26) ### Features * Add Otel Tracing helpers and tests ([#9070](#9070)) ([5111d52](5111d52)) * **gax:** Accept clientOptions in createApiCall for telemetry tracing ([#9176](#9176)) ([257a895](257a895)) ### Bug Fixes * **gax:** Fix several missing files from the monorepo merge ([#9209](#9209)) ([6fcd94d](6fcd94d)) * Turn on the gax vulnerability tests again ([#9204](#9204)) ([09609c8](09609c8)) </details> <details><summary>bigquery: 9.0.3</summary> ## [9.0.3](bigquery-v9.0.2...bigquery-v9.0.3) (2026-08-26) ### Bug Fixes * Patch the vulnerability for Bigquery and other REST based clients ([#9188](#9188)) ([94aac1e](94aac1e)) </details> <details><summary>health: 0.6.1</summary> ## [0.6.1](health-v0.6.0...health-v0.6.1) (2026-08-26) ### Bug Fixes * Upgrade sinon types for health package ([#9202](#9202)) ([b312515](b312515)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2 participants
Description
The gax tests were skipped because the version we needed hadn't been released yet. Also, the brittle require statement is breaking a unit test shard.
Impact
Adds test coverage and fixes the require statement.